[FEATURE] ViewHelpers without then/else return verdict#1031
Merged
Conversation
ViewHelpers that don't specify any then or else clause in any of the accepted syntax variants now directly return the result of the condition. Previously, this syntax was not supported and a no-op resulting in an empty string. Thus, this is not considered a breaking change, but an enhancement of the existing behavior.
s2b
force-pushed
the
feature/ifBooleanReturn
branch
from
f76d5a6 to
2ec9e67
Compare
lolli42
approved these changes
Feb 14, 2025
sbuerk
approved these changes
Feb 14, 2025
| '\'__then\' => %s,' . chr(10), | ||
| $templateCompiler->wrapChildNodesInClosure($node), | ||
| ); | ||
| if (!isset($node->getArguments()['else']) && $node->getChildNodes() === []) { |
Contributor
There was a problem hiding this comment.
I think this breaks the cache if only "then" is defined.
Contributor
There was a problem hiding this comment.
Hm there is an !isset($node->getArguments()['then']) check in the line above so this could not be the reason.
Here is my use case:
foo.bar is an empty array.
{f:if(condition: '{foo.bar -> f:count()} == 0', then: foo.baz)}
Returns true on first execution and '' on the second execution when it is cached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewHelpers that don't specify any then or else clause in any of the accepted syntax variants now directly return the result of the condition.
Previously, this syntax was not supported and a no-op resulting in an empty string. Thus, this is not considered a breaking change, but an enhancement of the existing behavior.