[BUGFIX] Use null instead of empty string as default for condition VHs#1050
Merged
[BUGFIX] Use null instead of empty string as default for condition VHs#1050
Conversation
This partially reverts 3084952: Now all condition-based ViewHelpers use `null` as default return value instead of `''` because this is more consistent when `then` or `else` returns `null`, for example if a non-existent variable is used there: ``` {f:if(condition: true, then: nonExistingVariable)} ``` This should return `null`, but now returns `''`. Note that this change is only a pre-patch, a follow-up will actually achieve the desired behavior from that example. For all other use-cases, this change shouldn't be a problem because `null` will be converted to `''` anyways.
Contributor
|
👍 |
sbuerk
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts 3084952: Now all condition-based ViewHelpers use
nullas default return value instead of''because this is moreconsistent when
thenorelsereturnsnull, for example if anon-existent variable is used there:
This should return
null, but now returns''. Note that this changeis only a pre-patch, a follow-up will actually achieve the desired
behavior from that example.
For all other use-cases, this change shouldn't be a problem because
nullwill be converted to''anyways.