[TASK] Add non-critical type hints to ViewHelper classes #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for more type hints in `ViewHelperInterface` and abstract classes, non-critical type hints are added to all existing ViewHelper classes. These include: * return types for `initializeArguments()` and `render()` * parameter and return types for internal methods Even though these changes most certainly aren't breaking, we still apply them to v5 only, just to be sure. In follow-up patches, the abstract classes will get more type hints (e. g. for properties), which will require (!) changes to the ViewHelpers and thus will be breaking changes.
s2b
force-pushed
the
task/viewHelperReturnTypes
branch
from
e8d7cf9 to
696016f
Compare
lolli42
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more type hints in
ViewHelperInterfaceandabstract classes, non-critical type hints are added to all existing
ViewHelper classes. These include:
initializeArguments()andrender()Even though these changes most certainly aren't breaking, we
still apply them to v5 only, just to be sure. In follow-up patches,
the abstract classes will get more type hints (e. g. for properties),
which will require (!) changes to the ViewHelpers and thus will
be breaking changes.