[TASK] Remove micro-optimization from HtmlspecialcharsViewHelper #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1151, it was already clarified that the `HtmlspecialcharsViewHelper` is in fact not used internally by Fluid. This means that we can also get rid of the custom compilation logic, which makes maintainance unnecessarily hard.
lolli42
approved these changes
Aug 15, 2025
s2b
added a commit
that referenced
this pull request
Aug 15, 2025
In #1151, it was already clarified that the `HtmlspecialcharsViewHelper` is in fact not used internally by Fluid. This means that we can also get rid of the custom compilation logic, which makes maintainance unnecessarily hard.
s2b
added a commit
that referenced
this pull request
Aug 15, 2025
In #1151, it was already clarified that the `HtmlspecialcharsViewHelper` is in fact not used internally by Fluid. This means that we can also get rid of the custom compilation logic, which makes maintainance unnecessarily hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1151, it was already clarified that the
HtmlspecialcharsViewHelperis in fact not used internally by Fluid. This means that we can also
get rid of the custom compilation logic, which makes maintainance
unnecessarily hard.