[TASK] Address deprecations introduced by PHP 8.5 #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses various deprecations that were introduced in recent dev versions of PHP 8.5. All changes should be non-breaking and thus can be backported to Fluid v4. * `TemplateParser` now uses empty strings instead of `null` as array key for runtime cache. Public API will be adjusted in v5 only. * `StandardVariableProvider` and `ViewHelperVariableContainer` use `__serialize()` instead of `__sleep()` for serialization. * GroupedForViewHelper ensures to use an empty string instead of `null` for array key to avoid the deprecation and considered non-breaking because php converted null-index to `""` index anyway.
sbuerk
approved these changes
Sep 13, 2025
s2b
added a commit
that referenced
this pull request
Sep 13, 2025
This patch addresses various deprecations that were introduced in recent dev versions of PHP 8.5. All changes should be non-breaking and thus can be backported to Fluid v4. * `TemplateParser` now uses empty strings instead of `null` as array key for runtime cache. Public API will be adjusted in v5 only. * `StandardVariableProvider` and `ViewHelperVariableContainer` use `__serialize()` instead of `__sleep()` for serialization. * GroupedForViewHelper ensures to use an empty string instead of `null` for array key to avoid the deprecation and considered non-breaking because php converted null-index to `""` index anyway.
s2b
added a commit
that referenced
this pull request
Sep 13, 2025
This patch addresses various deprecations that were introduced in recent dev versions of PHP 8.5. All changes should be non-breaking and thus can be backported to Fluid v4. * `TemplateParser` now uses empty strings instead of `null` as array key for runtime cache. Public API will be adjusted in v5 only. * `StandardVariableProvider` and `ViewHelperVariableContainer` use `__serialize()` instead of `__sleep()` for serialization. * GroupedForViewHelper ensures to use an empty string instead of `null` for array key to avoid the deprecation and considered non-breaking because php converted null-index to `""` index anyway.
s2b
added a commit
that referenced
this pull request
Sep 13, 2025
This is a follow-up from #1236. The internal changes are now reflected in the public method signatures as well.
s2b
added a commit
that referenced
this pull request
Sep 13, 2025
This is a follow-up from #1236. The internal changes are now reflected in the public method signatures as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses various deprecations that were introduced in
recent dev versions of PHP 8.5. All changes should be non-breaking
and thus can be backported to Fluid v4.
TemplateParsernow uses empty strings instead ofnullas arraykey for runtime cache. Public API will be adjusted in v5 only.
StandardVariableProviderandViewHelperVariableContaineruse__serialize()instead of__sleep()for serialization.nullfor array key to avoid the deprecation and considerednon-breaking because php converted null-index to
""indexanyway.