[TASK] Deprecate variables that start with a "_" #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for the possible introduction of more internal constants in Fluid, custom variable names that start with an underscore will no longer be allowed. For Fluid v4, a deprecation is emitted. In a follow-up for Fluid v5, the deprecation will be replaced with an exception. Related: #1166 Related: #1041
lolli42
approved these changes
Nov 3, 2025
s2b
added a commit
that referenced
this pull request
Nov 3, 2025
In preparation for the possible introduction of more internal constants in Fluid, custom variable names that start with an underscore will no longer be allowed. For Fluid v4, a deprecation is emitted. In a follow-up for Fluid v5, the deprecation will be replaced with an exception. Related: #1166 Related: #1041
s2b
added a commit
that referenced
this pull request
Nov 3, 2025
In preparation for the possible introduction of more internal constants in Fluid, custom variable names that start with an underscore will no longer be allowed. For Fluid v4, a deprecation is emitted. In a follow-up for Fluid v5, the deprecation will be replaced with an exception. Related: #1166 Related: #1041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the possible introduction of more internal
constants in Fluid, custom variable names that start with an
underscore will no longer be allowed.
For Fluid v4, a deprecation is emitted. In a follow-up for Fluid v5,
the deprecation will be replaced with an exception.
Related: #1166
Related: #1041