[TASK] Deprecate CDATA removal from templates (#1231) #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite early in the development of Fluid, the decision has been made to remove `<![CDATA[...]]>` sections from templates. The exact reason remains unclear, as 978071f only mentions that this has been added, but not why: > - replace cdata sections with empty lines (including nested cdata) As this modifies templates in an unnecessary way, this behavior is now deprecated: From Fluid 5 onwards, CDATA sections will just remain in Fluid templates untouched. Until then, a deprecation will be emitted to let users know that this will change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Deprecate CDATA removal from templates (#1231)
Quite early in the development of Fluid, the decision has been made
to remove
<![CDATA[...]]>sections from templates. The exact reasonremains unclear, as 978071f only
mentions that this has been added, but not why:
As this modifies templates in an unnecessary way, this behavior is now
deprecated: From Fluid 5 onwards, CDATA sections will just remain in
Fluid templates untouched. Until then, a deprecation will be emitted
to let users know that this will change in the future.