[BUGFIX] Ensure valid name for cache classes #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to refactorings in the cache layer of Fluid, which were necessary to make cache warmup feasible, the cache identifiers have changed with Fluid 5. This currently leads to parse errors when a template name starts with a number because the associated cache file and most importantly the generated PHP class name also starts with that number, which isn't allowed in PHP. This patch addresses that issue by prepending "template_" to cache identifiers. Other special characters are already dealt with in `TemplateCompiler`, so we only need to ensure that the identifier starts with an alpha-character. Resolves: #1266
sbuerk
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to refactorings in the cache layer of Fluid, which were necessary
to make cache warmup feasible, the cache identifiers have changed
with Fluid 5. This currently leads to parse errors when a template
name starts with a number because the associated cache file and most
importantly the generated PHP class name also starts with that number,
which isn't allowed in PHP.
This patch addresses that issue by prepending "template_" to cache
identifiers. Other special characters are already dealt with in
TemplateCompiler, so we only need to ensure that the identifierstarts with an alpha-character.
Resolves: #1266