[TASK] Share resolver delegates in cached templates (#1319)#1327
Merged
Conversation
Due to an oversight, each component call from a template created its own instance of the responsible ViewHelperResolverDelegate. This is not necessary, since resolver delegates are meant to be sharable. This patch introduces the new `getResolverDelegate()` method, which centralizes the already existing runtime cache for resolver delegate objects. All existing usages of `createResolverDelegateInstanceFromClassName()` are migrated to the new method. Note that the performance impact wasn't relevant in TYPO3, since the underlying DI implementation already shared the service objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an oversight, each component call from a template created its
own instance of the responsible ViewHelperResolverDelegate. This is
not necessary, since resolver delegates are meant to be sharable.
This patch introduces the new
getResolverDelegate()method, whichcentralizes the already existing runtime cache for resolver delegate
objects. All existing usages of
createResolverDelegateInstanceFromClassName()are migrated to thenew method.
Note that the performance impact wasn't relevant in TYPO3, since the
underlying DI implementation already shared the service objects.