[TASK] Option to collect multiple PhpDoc annotations#1361
Merged
Conversation
`ViewHelperMetaFactory`, which is used both for CLI commands (such as cache warmup and schema generation) and for automatic documentation, previously only collected the last instance of a PhpDoc annotation on a ViewHelper class: ``` /** * @see link1 * @see link2 */ ``` In that example, the metadata would always just contain `link2`. This patch introduces a new flag that allows collecting all instances of annotations. When set, `ViewHelperMetadata` always stores arrays instead of strings, even if only one instance of the annotation exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewHelperMetaFactory, which is used both for CLI commands (such as cache warmup and schema generation) and for automatic documentation, previously only collected the last instance of a PhpDoc annotation on a ViewHelper class:In that example, the metadata would always just contain
link2. This patch introduces a new flag that allows collecting all instances of annotations. When set,ViewHelperMetadataalways stores arrays instead of strings, even if only one instance of the annotation exists.