Conversation
symfony/polyfill-php84 1.33.0->1.34.0 adds RoundingMode stub [1]. round() in PHP < 8.4 allows int as third argument only, and has been extended with php 8.4 to allow int|RoundingMode. The 'class_exists()' check in RoundViewHelper now suddenly returns true when latest symfony/polyfill-php84 is loaded, and then feeds \RoundingMode enum to round() in php < 8.4, which fails with type error. Yay. The patch switches to a straight version check to trigger the PHP < 8.4 callback chain avoiding RoundingMode enum altogether, to avoid the symfony/polyfill-php84 influence. [1] symfony/polyfill-php84@e4e3f1c
sbuerk
approved these changes
Apr 16, 2026
s2b
approved these changes
Apr 16, 2026
lolli42
added a commit
that referenced
this pull request
Apr 16, 2026
symfony/polyfill-php84 1.33.0->1.34.0 adds RoundingMode stub [1]. round() in PHP < 8.4 allows int as third argument only, and has been extended with php 8.4 to allow int|RoundingMode. The 'class_exists()' check in RoundViewHelper now suddenly returns true when latest symfony/polyfill-php84 is loaded, and then feeds \RoundingMode enum to round() in php < 8.4, which fails with type error. Yay. The patch switches to a straight version check to trigger the PHP < 8.4 callback chain avoiding RoundingMode enum altogether, to avoid the symfony/polyfill-php84 influence. [1] symfony/polyfill-php84@e4e3f1c
lolli42
added a commit
that referenced
this pull request
Apr 16, 2026
symfony/polyfill-php84 1.33.0->1.34.0 adds RoundingMode stub [1]. round() in PHP < 8.4 allows int as third argument only, and has been extended with php 8.4 to allow int|RoundingMode. The 'class_exists()' check in RoundViewHelper now suddenly returns true when latest symfony/polyfill-php84 is loaded, and then feeds \RoundingMode enum to round() in php < 8.4, which fails with type error. Yay. The patch switches to a straight version check to trigger the PHP < 8.4 callback chain avoiding RoundingMode enum altogether, to avoid the symfony/polyfill-php84 influence. [1] symfony/polyfill-php84@e4e3f1c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symfony/polyfill-php84 1.33.0->1.34.0 adds RoundingMode stub [1].
round() in PHP < 8.4 allows int as third argument only, and has been extended with php 8.4 to allow int|RoundingMode.
The 'class_exists()' check in RoundViewHelper now suddenly returns true when latest symfony/polyfill-php84 is loaded, and then feeds \RoundingMode enum to round() in php < 8.4, which fails with type error. Yay.
The patch switches to a straight version check to trigger the PHP < 8.4 callback chain avoiding RoundingMode enum altogether, to avoid the symfony/polyfill-php84 influence.
[1] symfony/polyfill-php84@e4e3f1c