fix(tabgroup): reach settle up in the tablet two-pane - #335
Merged
Conversation
The two-pane layout inlined GroupDetailRoot and passed only part of its
callbacks, so settle-up, settlement taps and leave-group hit the silent
`= {}` defaults and did nothing.
Drive the panes from the back stack instead: a Nav3 SceneStrategy renders
the Group list entry together with the GroupDetail/SettleUp entries stacked
on it, marked via PaneRole metadata. Selection leaves GroupOverviewViewModel
and back pops the detail pane on its own. Detail entries stay composed so a
covered group keeps its selected tab. Compact widths fall through to the
single-pane scene, unchanged.
Drop the `= {}` defaults on GroupDetailRoot so no call site can skip a
callback silently again. In the shell, light the rail from the last
TopLevelTab in the stack and truncate the whole tab section on switch, so
detail entries neither darken their tab nor outlive it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-pane layout inlined GroupDetailRoot and passed only part of its callbacks, so settle-up, settlement taps and leave-group hit the silent
= {}defaults and did nothing.Drive the panes from the back stack instead: a Nav3 SceneStrategy renders the Group list entry together with the GroupDetail/SettleUp entries stacked on it, marked via PaneRole metadata. Selection leaves GroupOverviewViewModel and back pops the detail pane on its own. Detail entries stay composed so a covered group keeps its selected tab. Compact widths fall through to the single-pane scene, unchanged.
Drop the
= {}defaults on GroupDetailRoot so no call site can skip a callback silently again. In the shell, light the rail from the last TopLevelTab in the stack and truncate the whole tab section on switch, so detail entries neither darken their tab nor outlive it.