refactor(datagrid): drop redundant resize cursor and consolidate sort dispatch#1131
Merged
refactor(datagrid): drop redundant resize cursor and consolidate sort dispatch#1131
Conversation
…ogrammatic selection
…ache connection data
…ordinating protocol
…terial backgrounds
…date sort dispatch
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Base automatically changed from
refactor/datagrid-stage-11c-material-accessibility
to
main
May 8, 2026 18:54
12 tasks
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetCursorRects/viewDidMoveToWindow/layout/updateTrackingAreas/mouseMovedoverrides. AppKit'sNSTableHeaderViewalready adds the resize cursor at every column edge whoseresizingMask.contains(.userResizingMask). Remove the resize-zone bypass at the start ofmouseDown; the existingcolumnWidthsChangedpost-check handles drag-to-resize naturally.dataGridSort+dataGridRemoveSortColumn+dataGridClearSort) into onedataGridSortStateChanged(_ state: SortState).HeaderSortCycle.nextTransitionalready computes the fullnewState; the dispatch fan-out + coordinator's three-way re-derivation was double-bookkeeping.MainContentCoordinatorcollapseshandleSort+clearSort+removeMultiSortColumninto onehandleSortStateChanged(_:).Net delta: 12 files, +110 / −482 (−372 LoC). Multi-column sort, shift-click cycle (add → toggle → remove), priority-numbered chevrons, drag-to-resize, drag-to-reorder, "Don't Sort" context menu — all preserved.
Stacked on #1130. Review that one first.
Test plan