refactor(plugin-redis): replace recursive DisclosureGroup with OutlineGroup#1132
Merged
refactor(plugin-redis): replace recursive DisclosureGroup with OutlineGroup#1132
Conversation
…ogrammatic selection
…ache connection data
…ordinating protocol
…terial backgrounds
…date sort dispatch
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RedisKeyTreeViewpreviously rendered the namespace tree via a recursiverenderNodes(_:) -> AnyViewfunction with nestedForEach+DisclosureGroup. TheAnyViewwrap was needed because Swift can't express the recursive view-tree type, but it kills SwiftUI's view diffing.OutlineGroup(nodes, children: \.children)in 91 LoC. NoAnyView, no recursion in code — SwiftUI handles arbitrary depth.expandedPrefixes: Set<String>binding from the viewmodel and the call site. SwiftUI manages expansion state per branch identifier (viaRedisKeyNode.id); state persists across re-renders for branches whose ID survives, which matches what the explicit set was approximating.var children: [RedisKeyNode]?computed property toRedisKeyNode(returns the children array for.namespace, nil for.key) soOutlineGroupcan navigate.Picked SwiftUI
OutlineGroupover AppKitNSOutlineViewbecause the surrounding sidebar is a SwiftUIListwithSections; embeddingNSOutlineViewwould create a hybrid with its own scroll view, different selection chrome, and different keyboard nav.Stacked on #1131. Review that one first.
Test plan
user:1,user:2:profile,cache:foo,session:abc)