feat(datagrid): page-size menu, first/last buttons, and jump-to-page in the pagination bar#1408
Merged
Merged
Conversation
…age to the pagination bar (#1364)
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1364.
Replaces the minimal pagination control (Prev / "N of M" / Next plus a gear popover for limit and offset) with a richer bar for table tabs.
What's new
Design notes
goToPage, unknown-total Next, Show All). The table-browse data-loading path is unchanged.Menufor page size, four borderless SF Symbol buttons for navigation, and a popover with a text field for jump-to-page. macOS has no page-number or page-dots control (per the HIG), so there is no web-style pager.pageSize + 1probe, which keeps the data-loading path untouched. Trade-off: a table whose size is an exact multiple of the page size with an unknown total can show one empty page on Next (rare, self-correcting).Tests
PaginationStatetests:isLastPageKnown,canGoToNextPagewith known and unknown totals,goToNextPage(loadedRowCount:),goToPageguard with an unknown total.PaginationCoordinatorTests:goToPagerouting, and Next/Last behavior on an unknown total.Notes
String(localized:); the String Catalog picks them up on the next Xcode build, soLocalizable.xcstringsshould be committed after building.