Fix test target compilation (stale status bar init, missing imports)#1416
Merged
Conversation
…g SwiftUI/PluginKit imports)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TableProTests target does not compile on
main, so the whole test bundle (and CI's test phase) fails. Three test files drifted out of sync with recent feature merges:MainStatusBarLayoutTestsstill callsMainStatusBarView(...)with the old pagination callbacks (onLimitChange/onOffsetChange/onPaginationGo). The Improve pagination UI for query results (page navigation, page size selector) #1364 pagination PRs (feat(datagrid): page-size menu, first/last buttons, and jump-to-page in the pagination bar #1408, refactor(datagrid): de-duplicate pagination helpers and guard All rows on unknown totals (#1364) #1411) changed the initializer toonPageSizeChange/onShowAll/onGoToPage. Updated the call and sorted its imports.AWSIAMAuthTestsreads.id/.isSecureon aTableProPluginKittype without importing the module (from the AWS IAM work, Support RDS IAM Auth #1291). Addedimport TableProPluginKit.FillColumnTestsusesBinding.constant(...)without importing SwiftUI (from Fill Column, Feature Request: Edit Column for all rows in data #1304). Addedimport SwiftUI.After these, the test target builds again and
MainStatusBarLayoutTestspasses. No production code changed.