feat(results): add native result charts - #2222
Conversation
Visualize loaded query and table results without issuing additional database requests. Refs TableProApp#2107
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Pushed Three root causes account for most of it, so the fix is a refactor at three boundaries rather than 19 patches. 1. The chart's vocabulary was narrower than Swift Charts'.
2. A bound was treated as a terminal error. Every cap returned
3. A three-way router was collapsed into a bool.
Smaller ones: per-series dashes come from On finding 2 (the segment accessibility identifier): it does not reproduce. A measured AX probe shows a segmented Verified: Debug build passes. 160 unit tests pass across every touched suite, including new ones for the money-value regression, the chronological date axis, cap truncation, config survival across a result replacement, the default-Y rule, the bar banding, and the plural. One pre-existing lint error is untouched and not from this branch: |
Summary
Preview
All previews are full-window captures using the bundled Chinook sample database. The query charts invoice date, revenue, and billing country from 40 loaded rows.
Scope
Charts visualize loaded rows only. They do not fetch, aggregate, sample, or persist configuration. Pivot tables remain follow-up work.
Related to #2107. This implements the result-chart slice of item 4; pivot tables remain follow-up work.
Validation
TablePro.xcodeprojfromproject.ymlThe chart UI test now uses stable accessibility identifiers for the Chart segment and license gate. It compiles locally; the local UI runner was killed before bootstrapping, so GitHub Actions remains the authoritative runtime result for that test.