Skip to content

style: satisfy the swiftlint strict gate in the operation reporting code - #2293

Merged
datlechin merged 1 commit into
mainfrom
style/swiftlint-operation-reporting
Aug 20, 2026
Merged

style: satisfy the swiftlint strict gate in the operation reporting code#2293
datlechin merged 1 commit into
mainfrom
style/swiftlint-operation-reporting

Conversation

@datlechin

Copy link
Copy Markdown
Member

swiftlint lint --strict fails on main right now, on three violations that arrived with #2272:

TablePro/Core/Services/Operations/OperationDurationFormatter.swift:16:36: error: Number Separator Violation
TablePro/Core/Services/Operations/OperationDurationFormatter.swift:17:39: error: Number Separator Violation
TablePro/Core/Coordinators/RowEditingCoordinator+SaveChanges.swift:394:1: error: Extension Access Modifier Violation

That gate is the lint job in build.yml, and release needs it, so the next v* tag would have failed on this rather than on anything the tag introduced.

It merged unseen because PR CI never runs SwiftLint. macos-tests.yml builds and tests; only build.yml lints, and only on a tag. Worth closing separately, but this PR just clears the red.

The fix

  • 3600 becomes 3_600 in both places.
  • fileprivate moves from reportSaveFinished onto the extension that holds it, which is what extension_access_modifier asks for and what CLAUDE.md specifies under Code Style. The extension has one member, so the effective access is unchanged.

No behaviour change, so no CHANGELOG entry.

Verification

  • build PASS
  • lint TablePro PASS, 0 violations (was 3 errors)
  • test PASS, 111 of 111 across the suites touching the coordinators involved

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant