refactor: native patterns for feedback window, shortcut recorder, popover, query split#908
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 841d6a13fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| relativeTo bounds: NSRect, | ||
| of view: NSView, | ||
| preferredEdge: NSRectEdge = .maxY, | ||
| behavior: NSPopover.Behavior = .transient, |
There was a problem hiding this comment.
Changing the default NSPopover behavior to .transient breaks the autocomplete flow in FilterValueTextField: that popover is shown while the user keeps typing in the same text field, but .transient auto-closes on interactions outside the popover (the field editor). The coordinator only clears suggestionPopover in dismissSuggestions() and uses suggestionPopover != nil as the gate in updateSuggestions, so once auto-closed it can stay in a stale non-nil state and stop reopening/updating suggestions during the same edit session.
Useful? React with 👍 / 👎.
…rarchy, add CHANGELOG
841d6a1 to
f64fd1c
Compare
…rarchy, add CHANGELOG (#908)
…rarchy, add CHANGELOG (#908)
… calls for row actions (#916) * fix: use NSViewControllerRepresentable for proper view controller hierarchy, add CHANGELOG (#908) * refactor(datagrid): replace NotificationCenter dispatch with delegate calls for row actions * fix(perf): eliminate full NSTableView reload on delete, debounce lazy-load and inspector
1 participant
Summary
Net: -138 lines. All 4 changes replace custom implementations with native macOS APIs.
Test plan