Merged
Conversation
The native NSAlert that fired after the third successful connection felt bloaty and was steering users to a popup on the website that has also been removed. Drop the whole pipeline. Removed: - NewsletterPromptCoordinator (NSAlert + Safari opener) - AppDelegate registration call - successfulConnectionRecorded notification + the post site in DatabaseManager+Sessions - MacAnalyticsProvider successfulConnectionCount counter, newsletterPromptShown latch, markNewsletterPromptShown, and the Keys.successfulConnectionCount / Keys.newsletterPromptShown entries - Localized strings: "Stay updated on TablePro releases", "Get release notes ...", "Subscribe in Browser", "Maybe later" - Two MacAnalyticsProvider tests for the removed counter and latch - CHANGELOG entry for the prompt (it never shipped, so drop the line rather than add a "Removed" entry per project conventions) What stays: - markConnectionAttempted / markConnectionSucceeded / markFirstQueryExecuted write-once timestamps for the activation funnel telemetry remain unchanged.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The native NSAlert that fired after the third successful connection felt bloaty and was steering users to a popup on the website that has also been removed (
licensePR #44). Per user feedback, in-app and on-site auto-prompts add friction without enough conversion to justify them.Removed
NewsletterPromptCoordinator(NSAlert + Safari opener)AppDelegate.applicationDidFinishLaunchingregistration callNotification.Name.successfulConnectionRecorded+ its post site inDatabaseManager+SessionsMacAnalyticsProvider:successfulConnectionCountcounternewsletterPromptShownlatch +markNewsletterPromptShown()Keys.successfulConnectionCount,Keys.newsletterPromptShownMacAnalyticsProviderTestscases for the removed counter and latchWhat stays
The activation-funnel write-once timestamps (
markConnectionAttempted,markConnectionSucceeded,markFirstQueryExecuted) are unchanged. Those drive heartbeat analytics and are unrelated to the in-app prompt.Test plan
xcodebuild test -only-testing:TableProTests/MacAnalyticsProviderTestspasses