feat(datagrid): show column type in header hover tooltip (#435)#436
Merged
debba merged 7 commits intoJul 13, 2026
Merged
Conversation
Add a DataGrip-style tooltip that appears on column header hover showing "<name>: <type>" (e.g. "id: uuid"). The type is read from the already available columnMetadata (column data_type), so no backend changes are needed; it shows whenever column metadata is present (table browse) and is absent for arbitrary query results, which carry no per-column type. Reuses the existing floating-surface look via the reserved --bg-tooltip token. The native sort-hint title is suppressed while the type tooltip is shown to avoid two overlapping tooltips; query-result columns (no type) keep their sort hint. Closes TabularisDB#435
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by kimi-k2.6-20260420 · Input: 87.1K · Output: 9.4K · Cached: 138.3K |
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a DataGrip-style tooltip on data-grid column headers: hovering a header shows
<name>: <type>(e.g.id: uuid).Closes #435
How
columnMetadata(data_type) via the existingcolumnTypeMapinDataGrid.tsx— no backend changes.--bg-tooltiptheme token (bg-tooltip border border-strong rounded-lg shadow-xl), with the samegroup-hoverfade used elsewhere.absolute(notfixed) because the sticky<thead>carries atranslateYtransform, which would breakfixedanchoring.pointer-events-noneso it never intercepts header clicks/sort.titleis suppressed only while the type tooltip is shown, to avoid two overlapping tooltips on hover.Scope
Shows whenever column metadata is present (table browse). Arbitrary query results carry no per-column type in
QueryResult, so no tooltip is shown there — sort-hint title behavior is unchanged for those columns.Verification
pnpm typecheck— passpnpm exec eslint src/components/ui/DataGrid.tsx— passpnpm tauri dev(Postgres table browse).