fix(gdeq031t10): reset the panel at the start of a full init - #603
Merged
KenVanHoeylandt merged 1 commit intoJul 30, 2026
Merged
Conversation
The kernel-driver port dropped the reset pulse that the pre-migration driver issued at the top of initFull(). Without it a cold-booted panel never drives BUSY ready after CMD_POWER_ON, so device start fails with "Timed out waiting for panel BUSY" and takes kernel_init down with it — the LilyGO T-Deck Max does not boot on main. The rest of the driver already assumed the pulse was still there: waking from deep sleep relies on RST toggling "in init_full", and a mode change needs partial mode's lingering VCOM/data-interval setting cleared. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #602.
The kernel-driver port in #582 dropped the reset pulse that the pre-migration driver issued at the top of its full init:
hardware_reset()survived the port but is only reachable from thereset()display op, which nothing calls on the start path. Without the pulse a cold-booted controller never drives BUSY ready afterCMD_POWER_ON, sodisplayfails to start, and since a failed device start abortskernel_init, the LilyGO T-Deck Max does not boot at all on current main.Two comments in the driver already assume the pulse is still there, so this also restores deep-sleep wake and the register-default reset that a waveform-mode change relies on:
gdeq031t10_disp_on_off(): "Toggling RST (in init_full) also wakes the panel from deep sleep."reset()lived ininitFull()rather than at construction.Verification
Hardware, LilyGO T-Deck Max. Before:
After:
Boot completes, the SD card mounts, and refreshes run normally (
draw_bitmap: refresh_full,waited 1014 ms until not busy).Summary by CodeRabbit