Run executables directly

[KenVanHoeylandt]

• Apps can be launched directly from file paths (including Files app support)
• Added executable detection to identify unsupported or invalid binaries before launch.
• App startup is now streamlined through separate registered-app and direct-execution interfaces.
• Existing app launch points were migrated to the updated startup APIs.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 536f6021-7a3a-4bd8-98c7-9b1195c3c105

📥 Commits

Reviewing files that changed from the base of the PR and between dd40580 and 3f11b76.

📒 Files selected for processing (4)

• Modules/app-module/private/app/private/arguments.h
• Modules/app-module/source/manager.cpp
• Modules/app-module/tests/CMakeLists.txt
• Modules/app-module/tests/source/arguments_test.cpp

🚧 Files skipped from review as they are similar to previous changes (2)

• Modules/app-module/private/app/private/arguments.h
• Modules/app-module/source/manager.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds separate APIs for starting registered apps and executing apps from explicit locations. Shared startup code now handles arguments, streams, parent-child results, and manifest-less instances. ESP32 and POSIX loaders validate executable files before loading and expose executable checks. Applications, services, tests, and the file manager use the new APIs. SDK integration paths and tooling versions are updated.

Merge Risk: 🔵 Low · up to 3f11b

This change enables direct execution from Files, but Apple builds may expose Run for invalid shared-object content. The impact is bounded to an incorrect launch affordance, so the change is mergeable with owner awareness and follow-up.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 31.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 135 functions across 61 files. (1 skipped…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: enabling direct execution of executables, including ELF and shared object files.

Full details: Docstring Coverage

Explanation

Docstring coverage is 31.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 135 functions across 61 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch app-improvements

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f06b09dc-27e9-4aba-b418-4b3c86152a95

📥 Commits

Reviewing files that changed from the base of the PR and between 643cbc3 and e0f3c42.

📒 Files selected for processing (17)

• Modules/app-esp32-module/source/app_esp32_loader_service.cpp
• Modules/app-module/include/app/elf_check.h
• Modules/app-module/include/app/exec.h
• Modules/app-module/include/app/loader.h
• Modules/app-module/private/app/private/exec_internal.h
• Modules/app-module/source/elf_check.cpp
• Modules/app-module/source/exec.cpp
• Modules/app-module/source/internal_loader.cpp
• Modules/app-module/source/module.cpp
• Modules/app-module/tests/source/exec_test.cpp
• Modules/app-posix-module/source/app_posix_loader_service.cpp
• Modules/app-posix-module/tests/CMakeLists.txt
• Modules/app-posix-module/tests/source/loader_test.cpp
• Tactility/Private/Tactility/app/files/View.h
• Tactility/Source/app/files/View.cpp
• Tests/SdkIntegration/main/CMakeLists.txt
• Tests/SdkIntegration/tactility.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Modules/app-esp32-module/source/app_esp32_loader_service.cpp (1)

163-164: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Reject null AppLocation::location values for APP_LOCATION_PATH.

AppLocation does not define a non-null contract. Both loaders pass location.location to a std::string parameter without validation. A null value can terminate or crash during string construction. Enforce this precondition in the public path entry points, including api_load() and api_is_executable().

🧹 Nitpick comments (1)

Modules/app-module/tests/source/execute_test.cpp (1)

136-138: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add direct app_execute() path coverage.

The POSIX suite executes FIXTURE_APP_PATH through app_start_for_result(), but no test calls app_execute() with APP_LOCATION_PATH. Add this case to the POSIX integration suite and verify the fixture lifecycle and result.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: dd00113f-0317-491c-a115-1c5a3a537b6f

📥 Commits

Reviewing files that changed from the base of the PR and between a58638c and 43ccaf0.

📒 Files selected for processing (49)

• Modules/app-esp32-module/source/app_esp32_loader_service.cpp
• Modules/app-module/include/app/execute.h
• Modules/app-module/include/app/manager.h
• Modules/app-module/include/app/start.h
• Modules/app-module/include/app/stream.h
• Modules/app-module/private/app/private/ledger.h
• Modules/app-module/private/app/private/manager_internal.h
• Modules/app-module/source/execute.cpp
• Modules/app-module/source/manager.cpp
• Modules/app-module/source/module.cpp
• Modules/app-module/source/scheduler.cpp
• Modules/app-module/source/start.cpp
• Modules/app-module/tests/source/execute_test.cpp
• Modules/app-module/tests/source/io_test.cpp
• Modules/app-module/tests/source/manager_test.cpp
• Modules/app-module/tests/source/stream_test.cpp
• Modules/app-posix-module/source/app_posix_loader_service.cpp
• Modules/app-posix-module/tests/source/loader_test.cpp
• Tactility/Include/Tactility/app/fileselection/FileSelection.h
• Tactility/Include/Tactility/app/wifimanage/WifiManage.h
• Tactility/Source/Tactility.cpp
• Tactility/Source/app/alertdialog/AlertDialog.cpp
• Tactility/Source/app/appdetails/AppDetails.cpp
• Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
• Tactility/Source/app/applist/AppList.cpp
• Tactility/Source/app/boot/Boot.cpp
• Tactility/Source/app/btmanage/BtManage.cpp
• Tactility/Source/app/btpeersettings/BtPeerSettings.cpp
• Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp
• Tactility/Source/app/development/Development.cpp
• Tactility/Source/app/files/View.cpp
• Tactility/Source/app/fileselection/FileSelection.cpp
• Tactility/Source/app/gpssettings/GpsSettings.cpp
• Tactility/Source/app/i2cscanner/I2cScanner.cpp
• Tactility/Source/app/imageviewer/ImageViewer.cpp
• Tactility/Source/app/inputdialog/InputDialog.cpp
• Tactility/Source/app/launcher/Launcher.cpp
• Tactility/Source/app/notes/Notes.cpp
• Tactility/Source/app/selectiondialog/SelectionDialog.cpp
• Tactility/Source/app/settings/Settings.cpp
• Tactility/Source/app/setup/Setup.cpp
• Tactility/Source/app/timedatesettings/TimeDateSettings.cpp
• Tactility/Source/app/timezone/TimeZone.cpp
• Tactility/Source/app/touchcalibration/TouchCalibration.cpp
• Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
• Tactility/Source/app/wificonnect/WifiConnect.cpp
• Tactility/Source/app/wifimanage/WifiManage.cpp
• Tactility/Source/service/development/DevelopmentService.cpp
• Tactility/Source/service/webserver/WebServerService.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• Modules/app-module/private/app/private/ledger.h

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: cf985051-4ff7-4192-8db9-99dfb50fdb96

📥 Commits

Reviewing files that changed from the base of the PR and between 43ccaf0 and dd40580.

📒 Files selected for processing (6)

• Modules/app-module/include/app/execute.h
• Modules/app-module/private/app/private/arguments.h
• Modules/app-module/private/app/private/ledger.h
• Modules/app-module/source/internal_loader.cpp
• Modules/app-module/source/manager.cpp
• Modules/app-module/source/scheduler.cpp

💤 Files with no reviewable changes (2)

• Modules/app-module/private/app/private/ledger.h
• Modules/app-module/source/internal_loader.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• Modules/app-module/include/app/execute.h

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.