Skip to content

Remove file mutex usage - #43

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
file-mutex-removal
Aug 27, 2026
Merged

Remove file mutex usage#43
KenVanHoeylandt merged 1 commit into
mainfrom
file-mutex-removal

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The API is removed from the upcoming SDK.

Summary by CodeRabbit

  • Updates
    • Updated Diceware to version 0.13.0.
    • Updated Epub Reader to version 0.10.0.
    • Updated Todo List to version 0.12.0.
  • Improvements
    • Streamlined file access across Diceware, Epub Reader, and Todo List for simpler and more efficient reading and saving.
    • Todo List data continues to load and save directly through the app’s file storage.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Diceware now reads its wordlist without filesystem mutex operations. Epub Reader removes filesystem mutex handling from background text-file reads and EPUB parsing. Todo List removes mutex handling from save and load operations. The Diceware, Epub Reader, and Todo List manifest versions are incremented to 0.13.0, 0.10.0, and 0.12.0.

Merge Risk: ⚪ Minimal · up to b75b5

This PR removes obsolete filesystem-mutex usage from a few app paths and updates one app version. A localized comment still references the removed lock, but no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing file mutex usage from the affected applications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch file-mutex-removal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Apps/EpubReader/main/Source/EpubReaderAsync.cpp (1)

114-116: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Update comments that still describe the removed filesystem mutex.

asyncOpenComplete still says that text was read “under the FS lock” and that empty content can indicate a “lock timeout”. This path no longer uses the mutex. Update those comments to describe only read errors.

Proposed comment update
-            // Content was pre-read in backgroundOpenTask (under the FS lock) -
+            // Content was pre-read in backgroundOpenTask -
             // no SD I/O needed here on the LVGL task.

-            // Text content empty (lock timeout or read error) - show error in browser
+            // Text content empty (read error) - show error in browser

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d25e101f-c568-4ad6-a4fa-6841e17f2386

📥 Commits

Reviewing files that changed from the base of the PR and between 55328ce and b75b58d.

📒 Files selected for processing (6)
  • Apps/Diceware/main/Source/Diceware.cpp
  • Apps/Diceware/manifest.properties
  • Apps/EpubReader/main/Source/EpubReaderAsync.cpp
  • Apps/EpubReader/manifest.properties
  • Apps/TodoList/main/Source/TodoList.cpp
  • Apps/TodoList/manifest.properties
💤 Files with no reviewable changes (2)
  • Apps/TodoList/main/Source/TodoList.cpp
  • Apps/Diceware/main/Source/Diceware.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

@KenVanHoeylandt
KenVanHoeylandt merged commit 2ca256e into main Aug 27, 2026
21 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the file-mutex-removal branch August 27, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant