refactor: split ThumbRenderer class - #1462
Merged
Merged
Conversation
CyanVoxel
added
the
Type: Refactor
CyanVoxel
added
Type: UI/UX
CyanVoxel
marked this pull request as draft
July 25, 2026 22:13
CyanVoxel
marked this pull request as ready for review
July 25, 2026 22:15
Computerdores
left a comment
Computerdores
left a comment
Collaborator
There was a problem hiding this comment.
Mostly looks good
FYI: I reviewed under the assumption, that you only extracted the rendering methods in the first commit and didn't change them
Sola-ris
reviewed
Aug 1, 2026
github-project-automation
Bot
moved this from 🚧 In progress
to ✅ Done
in TagStudio Development
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits up the
ThumbnailRendererclass into smaller classes and functions inside a newrenderers/directory and consolidates code inside them (specifically for the functions moved inside thearchive.pyfile, the rest is basically untouched)NOTE: I'd like to move the
renderer.pyfile into this directory as well, but haven't done so in this PR as a move within the same PR as these changes would result in the moved file losing the git history. That can come later along with several other file renames/moves.Takes over for #1217, progress towards #1460.
Tasks Completed