chore(ci): use GITHUB_TOKEN instead of NPM_TOKEN PAT - #5845
Merged
Conversation
Drops the dependency on a personal PAT stored as the NPM_TOKEN secret. GITHUB_TOKEN can auth to npm.pkg.github.com for both installing our GitHub Packages deps (once @talend/locales-* are made public - PAT was only required for that cross-repo read) and publishing talend/ui's own packages (same-repo write). Adds packages: read/write permission where needed since jobs with an explicit permissions block otherwise default unlisted scopes to none. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
jmfrancois
temporarily deployed
to
pull_request_unsafe
September 4, 2026 06:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
September 4, 2026 06:32 — with
GitHub Actions
Failure
GitHub Actions
Failure
jmfrancois
temporarily deployed
to
pull_request_unsafe
September 4, 2026 06:32 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Storybook for this PR deployed on this github page |
jmfrancois
marked this pull request as ready for review
September 4, 2026 06:39
jmfrancois
had a problem deploying
to
pull_request_unsafe
September 4, 2026 07:09 — with
GitHub Actions
Failure
GitHub Actions
Failure
jmfrancois
temporarily deployed
to
pull_request_unsafe
September 4, 2026 09:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jmfrancois
temporarily deployed
to
pull_request_unsafe
September 4, 2026 09:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jmfrancois
temporarily deployed
to
pull_request_unsafe
September 4, 2026 09:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
CI relies on a personal PAT (
NPM_TOKENsecret) to auth againstnpm.pkg.github.comfor installing@talend/locales-*packages. That's a personal token as a shared org secret — bus-factor / offboarding risk, and gives CI more privilege than it needs.What is the chosen solution to this problem?
Swap
secrets.NPM_TOKENfor the built-ingithub.token(GITHUB_TOKEN) everywhere in.github/workflows/*and.github/actions/setup-node. This works for:changeset.yml/pre-release.yml, same-repo write — addedpackages: write/packages: readto the relevant workflowpermissionsblocks, since an explicitpermissions:block zeroes any unlisted scope)@talend/locales-*, which are published from a different, currently-private repo (Talend/i18n-product) —GITHUB_TOKENcannot read cross-repo private packages, PAT-free or notTalend/i18n-productneeds to flip the@talend/locales-*packages to public visibility. Without that, install steps will 401 on those packages once the PAT is gone. Once merged and packages are public, theNPM_TOKENorg/repo secret can be deleted.Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change