Support multiple integrations of the same type per game - #1048
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1048 +/- ##
===========================================
+ Coverage 98.42% 98.43% +0.01%
===========================================
Files 477 477
Lines 7613 7618 +5
Branches 999 996 -3
===========================================
+ Hits 7493 7499 +6
Misses 49 49
+ Partials 71 70 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tudddorrr
force-pushed
the
multiple-integrations-of-the-same-type
branch
from
September 5, 2026 12:17
64761fd to
704cd42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entity model
SteamworksLeaderboardMappingcomposite primary key now includesintegration_id, so the same Talo leaderboard can map to different Steamworks leaderboards across integrations.SteamworksLeaderboardEntryFK and unique constraint widened to includeintegration_id.SteamworksPlayerStatgains anintegrationFK with a unique constraint on(integration_id, player_stat_id)replacing the oldplayer_stat_idunique.integration_idfrom the game's existing Steamworks integration, then enforce NOT NULL.Duplicate detection
appId,clientId, orbundleId).Player resolution
PlayerAlias.resolveIdentifierloads all integrations of the matching type (newest first) and tries each until one succeeds, so a ticket valid against one app is accepted even when other integrations exist.Integration.getPlayerIdentifiernow returns a uniform{ identifier, initialPlayerProps }shape instead of a union of per-service result types.Integration triggering
triggerIntegrationsruns integrations sequentially instead ofPromise.alland catches per-integration errors, so one failing integration no longer blocks the rest.Cleanup tasks
cleanupSteamworksLeaderboardEntriesandcleanupSteamworksPlayerStatspopulate and follow the directintegrationrelation instead of resolving it through game lookups, simplifying the logic and removing orphan-handling fallbacks.