Skip to content

Release 0.64.0#430

Merged
tudddorrr merged 10 commits intomainfrom
develop
Dec 5, 2025
Merged

Release 0.64.0#430
tudddorrr merged 10 commits intomainfrom
develop

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

dependabot bot and others added 10 commits November 15, 2025 11:04
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Update dependency @types/react to v18.3.27
@tudddorrr tudddorrr added the release This pull request contains a release label Dec 5, 2025
@claude
Copy link

claude bot commented Dec 5, 2025

PR Review: Release 0.64.0

This PR looks good overall! The changes are clean and well-tested. I found one potential issue to verify:


🟡 Code Quality & Best Practices

TimePeriodPicker hover state specificity (src/components/TimePeriodPicker.tsx:25)

The removal of !important from the hover class could cause specificity issues:

// Current (after this PR):
className={clsx(buttonClassName, { 'bg-indigo-500 hover:bg-indigo-500': period.id === selectedPeriod })}

The buttonClassName includes hover:bg-gray-900, and the selected state adds hover:bg-indigo-500. While clsx places the conditional classes after buttonClassName in the string, Tailwind CSS v4's cascade layer system means both hover utilities have equal specificity without the !important modifier.

Recommendation: Verify in the browser that selected buttons maintain their indigo background color on hover (not reverting to gray). If there's an issue, restore the !important modifier:

className={clsx(buttonClassName, { 'bg-indigo-500 hover:!bg-indigo-500': period.id === selectedPeriod })}

✅ Potential Bugs

No issues found.


✅ Performance

No issues found.


✅ Security

No issues found.


Other notes:

  • The "1d" (Today) time period addition is properly implemented with tests
  • Workflow changes improve review structure and clarity
  • CLAUDE.md provides excellent project documentation

@tudddorrr tudddorrr merged commit 4b3741d into main Dec 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release This pull request contains a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant