Skip to content

Replace ChannelStoragePropError with RejectedProp#222

Merged
tudddorrr merged 1 commit into
developfrom
replace-channel-storage-prop-error
Jul 4, 2026
Merged

Replace ChannelStoragePropError with RejectedProp#222
tudddorrr merged 1 commit into
developfrom
replace-channel-storage-prop-error

Conversation

@tudddorrr

@tudddorrr tudddorrr commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Type consolidation

  • Removed the now-redundant ChannelStoragePropError class (which had identical fields key, error, message as RejectedProp)
  • Replaced all ChannelStoragePropError[] references with the pre-existing RejectedProp[] in ChannelsAPI.OnChannelStoragePropsFailedToSet, the response DTO, and sample UI code
  • Unifies failed-prop error reporting across channels so callers see a single type (RejectedProp) whether props are rejected during a set operation or via the existing OnChannelPropsRejected event

@tudddorrr tudddorrr added the breaking This pull request contains a breaking change label Jul 4, 2026
@tudddorrr
tudddorrr merged commit 25b34c4 into develop Jul 4, 2026
3 checks passed
@tudddorrr
tudddorrr deleted the replace-channel-storage-prop-error branch July 4, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This pull request contains a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant