Skip to content

Return player alias from OnIdentified event#223

Merged
tudddorrr merged 1 commit into
developfrom
identify-player-alias
Jul 4, 2026
Merged

Return player alias from OnIdentified event#223
tudddorrr merged 1 commit into
developfrom
identify-player-alias

Conversation

@tudddorrr

@tudddorrr tudddorrr commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

OnIdentified event signature

  • Changed PlayersAPI.OnIdentified from Action<Player> to Action<PlayerAlias>, so subscribers now receive the alias object directly instead of the full player object

Identify method return types

  • Identify, IdentifySteam, IdentifyGooglePlayGames, IdentifyGameCenter, and HandleIdentifySuccess all return Task<PlayerAlias> instead of Task<Player>, eliminating the need for consumers to access Talo.CurrentPlayer after calling these methods

Dead code elimination

  • Removed redundant return Talo.CurrentPlayer lines from IdentifySteam, IdentifyGooglePlayGames, and IdentifyGameCenter since the underlying Identify() call now returns the alias directly, making the API surface more consistent and predictable

@tudddorrr tudddorrr added the breaking This pull request contains a breaking change label Jul 4, 2026
@tudddorrr
tudddorrr merged commit 240ca42 into develop Jul 4, 2026
3 checks passed
@tudddorrr
tudddorrr deleted the identify-player-alias branch July 4, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This pull request contains a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant