Remove prop rejection events, keep them inline with update results - #228
Merged
Conversation
tudddorrr
force-pushed
the
remove-prop-rejection-events
branch
3 times, most recently
from
August 4, 2026 20:42
f22a92b to
d747e70
Compare
tudddorrr
force-pushed
the
remove-prop-rejection-events
branch
from
August 4, 2026 21:01
d747e70 to
f3640b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result types replacing event-based error handling
ChannelsAPI.CreateandUpdatenow returnChannelUpsertResultinstead ofChanneldirectly, wrapping success/failure status, the channel, and any rejected props.FeedbackAPI.Sendnow returnsFeedbackSendResultinstead of void, including success status and rejected props.LeaderboardsAPI.AddEntrynow returnsAddEntryResultinstead of a tuple(LeaderboardEntry, bool), adding success status and rejected props.PlayersAPIno longer firesOnPropsRejectedseparately; rejected props are returned directly viaSetPropand the existingOnPlayerUpdatedevent.Removal of RejectedProp event emissions
RejectedProp.TryEmitwas removed entirely, as the pattern of emitting rejected props via events is no longer used.OnChannelPropsRejectedandOnPropsRejectedevents were removed fromChannelsAPI,FeedbackAPI,LeaderboardsAPI, andPlayersAPI.Sample updates for new API shapes
Success/Entryproperties instead of relying on events or tuples.