Skip to content

Refresh comparison bundle baseline - #39

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/refresh-comparison-bundle-baseline
Aug 2, 2026
Merged

Refresh comparison bundle baseline#39
tannerlinsley merged 1 commit into
mainfrom
taren/refresh-comparison-bundle-baseline

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Aug 2, 2026

Copy link
Copy Markdown
Member

What changed

  • refresh the comparison bundle baseline from the exact Ubuntu candidate produced by main run 30733331406
  • record the intentional geometry-interaction bundle cost from PR Add geometry-aware point selection #29
  • synchronize the public comparison evidence with the new baseline

Root cause

PR #29 changed the measured chart-core inputs but merged without updating benchmarks/comparison/bundle-baseline.json. The same revision mismatch and bundle-threshold failure reproduced on main and PR #37.

Validation

  • pnpm benchmark:check
  • pnpm docs:check
  • pnpm run validate
  • git diff --check

The candidate contains all 60 cases, changes only the 12 TanStack cases, and records source revision 76bcdbb at package version 0.5.1.

Summary by CodeRabbit

  • Documentation

    • Updated bundle comparison references with the latest workspace revision and baseline date.
    • Revised the documented TanStack Charts bundle size range to 28.47–33.89 KiB.
  • Chores

    • Refreshed bundle size metrics, compression values, package metadata, and comparison baselines.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a05898eb-ab2a-46bd-96a8-5be9e7176e3a

📥 Commits

Reviewing files that changed from the base of the PR and between acf1909 and 87147aa.

📒 Files selected for processing (3)
  • benchmarks/comparison/bundle-baseline.json
  • docs/comparison.md
  • packages/charts-core/docs/comparison.md

📝 Walkthrough

Walkthrough

The bundle baseline now uses updated TanStack metadata and regenerated size measurements. Both comparison documents report the new workspace revision, snapshot date, and controlled bundle range.

Changes

Bundle comparison refresh

Layer / File(s) Summary
Refresh bundle baseline measurements
benchmarks/comparison/bundle-baseline.json
Updated the generation metadata, package version, workspace revision, and bundle size metrics for TanStack bundles.
Synchronize comparison documentation
docs/comparison.md, packages/charts-core/docs/comparison.md
Updated the measured revision, baseline date, and controlled TanStack Charts bundle range in both comparison documents.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/refresh-comparison-bundle-baseline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit 69a8244 into main Aug 2, 2026
13 of 15 checks passed
@tannerlinsley
tannerlinsley deleted the taren/refresh-comparison-bundle-baseline branch August 2, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant