Fix bigint serialization in pg-serializer #932
Merged
+264
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for serializing BigInt values to strings - Fix error message to handle non-JSON-serializable values (like BigInt) which was causing a secondary "Do not know how to serialize a BigInt" error from JSON.stringify instead of the intended error message - Add comprehensive unit tests for pg-serializer with 100% coverage
🦋 Changeset detectedLatest commit: 6900878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 87.1 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.34 kB ℹ️ View Unchanged
|
Collaborator
|
@KyleAMathews looks good but perhaps we should add an e2e test to validate that this works when using a bigint as a predicate that's pushed to electric. I'm 99% sure this will work. |
LGTM…down Add e2e tests to verify BigInt values work correctly when used as predicates that are pushed to Electric: - Test eq() with BigInt on BIGINT column - Test inArray() with BigInt array on BIGINT column Both tests use values exceeding Number.MAX_SAFE_INTEGER to ensure the serialization preserves precision.
Move BigInt predicate tests from Electric-specific to the shared test suite so they run for all collection implementations: - Add `largeViewCount: bigint` field to Post type - Generate seed data with BigInt values exceeding MAX_SAFE_INTEGER - Add eq() and gt() tests for BigInt comparison operators - Add inArray() test for BigInt array predicates - Update Electric e2e test setup to include the new BIGINT column This ensures BigInt serialization is tested across all collection backends, not just Electric.
…ilter Add BigInt handling to serializeValue function to prevent "Do not know how to serialize a BigInt" error when using BigInt values in predicates with Query collections.
Collaborator
Author
|
Ah good call, added an e2e test |
KyleAMathews
deleted the
claude/fix-db-serialization-01Jn43VmaGXq3fLxsxXWe6Rz
branch
Merged
Contributor
|
🎉 This PR has been released! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact