Unit tests for data equality comparison

[kevin-dp]

Added some unit tests to check whether eq works properly on Dates because according to #934 dates are compared by reference instead of by value. However, the tests seem to indicate that the dates are being compared by value and thus are working as expected.

Looking at the code, we do normalize the values before comparing them:

db/packages/db/src/query/compiler/evaluators.ts

Lines 165 to 178 in 7aedf12

	case `eq`: {
	const argA = compiledArgs[0]!
	const argB = compiledArgs[1]!
	return (data) => {
	const a = normalizeValue(argA(data))
	const b = normalizeValue(argB(data))
	// In 3-valued logic, any comparison with null/undefined returns UNKNOWN
	if (isUnknown(a) || isUnknown(b)) {
	return null
	}
	// Use areValuesEqual for proper Uint8Array/Buffer comparison
	return areValuesEqual(a, b)
	}
	}

The normalization transforms dates into epoch numbers:

db/packages/db/src/utils/comparison.ts

Lines 142 to 145 in 7aedf12

	export function normalizeValue(value: any): any {
	if (value instanceof Date) {
	return value.getTime()
	}

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1293b1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

More templates

• todos
• tanstack-start-example-basic
• @tanstack/db-example-paced-mutations-demo
• tanstack-start-db-projects-example
• @tanstack/db-example-react-todo
• @tanstack/db-example-solid-todo

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@992

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@992

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@992

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@992

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@992

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@992

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@992

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@992

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@992

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@992

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@992

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@992

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@992

commit: 1293b1b

[github-actions]

Size Change: 0 B

Total Size: 88.2 kB

ℹ️ View Unchanged

Filename	Size
./packages/db/dist/esm/collection/change-events.js	1.39 kB
./packages/db/dist/esm/collection/changes.js	977 B
./packages/db/dist/esm/collection/events.js	388 B
./packages/db/dist/esm/collection/index.js	3.24 kB
./packages/db/dist/esm/collection/indexes.js	1.1 kB
./packages/db/dist/esm/collection/lifecycle.js	1.67 kB
./packages/db/dist/esm/collection/mutations.js	2.31 kB
./packages/db/dist/esm/collection/state.js	3.42 kB
./packages/db/dist/esm/collection/subscription.js	2.71 kB
./packages/db/dist/esm/collection/sync.js	2.37 kB
./packages/db/dist/esm/deferred.js	207 B
./packages/db/dist/esm/errors.js	4.19 kB
./packages/db/dist/esm/event-emitter.js	748 B
./packages/db/dist/esm/index.js	2.66 kB
./packages/db/dist/esm/indexes/auto-index.js	742 B
./packages/db/dist/esm/indexes/base-index.js	766 B
./packages/db/dist/esm/indexes/btree-index.js	1.93 kB
./packages/db/dist/esm/indexes/lazy-index.js	1.1 kB
./packages/db/dist/esm/indexes/reverse-index.js	513 B
./packages/db/dist/esm/local-only.js	837 B
./packages/db/dist/esm/local-storage.js	2.1 kB
./packages/db/dist/esm/optimistic-action.js	359 B
./packages/db/dist/esm/paced-mutations.js	496 B
./packages/db/dist/esm/proxy.js	3.75 kB
./packages/db/dist/esm/query/builder/functions.js	733 B
./packages/db/dist/esm/query/builder/index.js	3.96 kB
./packages/db/dist/esm/query/builder/ref-proxy.js	917 B
./packages/db/dist/esm/query/compiler/evaluators.js	1.35 kB
./packages/db/dist/esm/query/compiler/expressions.js	430 B
./packages/db/dist/esm/query/compiler/group-by.js	1.8 kB
./packages/db/dist/esm/query/compiler/index.js	1.96 kB
./packages/db/dist/esm/query/compiler/joins.js	2 kB
./packages/db/dist/esm/query/compiler/order-by.js	1.46 kB
./packages/db/dist/esm/query/compiler/select.js	1.07 kB
./packages/db/dist/esm/query/expression-helpers.js	1.43 kB
./packages/db/dist/esm/query/ir.js	673 B
./packages/db/dist/esm/query/live-query-collection.js	360 B
./packages/db/dist/esm/query/live/collection-config-builder.js	5.33 kB
./packages/db/dist/esm/query/live/collection-registry.js	264 B
./packages/db/dist/esm/query/live/collection-subscriber.js	1.74 kB
./packages/db/dist/esm/query/live/internal.js	130 B
./packages/db/dist/esm/query/optimizer.js	2.56 kB
./packages/db/dist/esm/query/predicate-utils.js	2.91 kB
./packages/db/dist/esm/query/subset-dedupe.js	921 B
./packages/db/dist/esm/scheduler.js	1.3 kB
./packages/db/dist/esm/SortedMap.js	1.3 kB
./packages/db/dist/esm/strategies/debounceStrategy.js	247 B
./packages/db/dist/esm/strategies/queueStrategy.js	428 B
./packages/db/dist/esm/strategies/throttleStrategy.js	246 B
./packages/db/dist/esm/transactions.js	2.9 kB
./packages/db/dist/esm/utils.js	881 B
./packages/db/dist/esm/utils/browser-polyfills.js	304 B
./packages/db/dist/esm/utils/btree.js	5.61 kB
./packages/db/dist/esm/utils/comparison.js	852 B
./packages/db/dist/esm/utils/cursor.js	457 B
./packages/db/dist/esm/utils/index-optimization.js	1.51 kB
./packages/db/dist/esm/utils/type-guards.js	157 B

_{compressed-size-action::db-package-size}

[github-actions]

Size Change: 0 B

Total Size: 3.35 kB

ℹ️ View Unchanged

Filename	Size
./packages/react-db/dist/esm/index.js	225 B
./packages/react-db/dist/esm/useLiveInfiniteQuery.js	1.17 kB
./packages/react-db/dist/esm/useLiveQuery.js	1.12 kB
./packages/react-db/dist/esm/useLiveSuspenseQuery.js	431 B
./packages/react-db/dist/esm/usePacedMutations.js	401 B

_{compressed-size-action::react-db-package-size}

[samwillis]

Tests look good, but unsure about the package.json and pnpm-lock change?

Approving for when you address that

[samwillis]

Has this leaked in from another branch, or due to where you branched off?

[kevin-dp]

It wouldn't compile for me. I assumed it is due to renovate having upgraded something and now requiring this package explicitly.