fix(hotkeys): recognize contenteditable="plaintext-only" in isInputElement#51
Merged
KevinVandy merged 1 commit intoTanStack:mainfrom Mar 6, 2026
Conversation
Use element.isContentEditable instead of checking contentEditable string values. This covers plaintext-only and inherited contenteditable, which were previously missed causing hotkeys to fire in editable elements. Closes TanStack#50 Made-with: Cursor
KevinVandy
approved these changes
Mar 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Summary
isInputElement()previously checkedelement.contentEditableagainst'true'and'', missing'plaintext-only'and inherited contenteditable. This caused hotkeys withignoreInputs: true(the default for single keys like Backspace/Delete) to fire while typing incontenteditable="plaintext-only"elements.Replaced the string comparison with
element.isContentEditable, a computed boolean that covers all editable states:contenteditable="true"contenteditable=""contenteditable="plaintext-only"Test plan
contenteditable="plaintext-only"element is recognized as inputMade with Cursor