Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-is-input-element-plaintext-only.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/hotkeys': patch
---

fix(isInputElement): recognize contenteditable="plaintext-only" and inherited contenteditable
10 changes: 4 additions & 6 deletions packages/hotkeys/src/manager.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,10 @@ export function isInputElement(element: EventTarget | null): boolean {
return true
}

// Check for contenteditable elements
if (element instanceof HTMLElement) {
const contentEditable = element.contentEditable
if (contentEditable === 'true' || contentEditable === '') {
return true
}
// Check for contenteditable elements (includes "true", "", "plaintext-only",
// and inherited contenteditable from ancestor elements)
if (element instanceof HTMLElement && element.isContentEditable) {
return true
}

return false
Expand Down
17 changes: 17 additions & 0 deletions packages/hotkeys/tests/manager.utils.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'

import {
defaultHotkeyOptions,
getDefaultIgnoreInputs,
Expand Down Expand Up @@ -53,6 +54,22 @@ describe('manager.utils', () => {
expect(isInputElement(div)).toBe(true)
})

it('should return true for contenteditable plaintext-only elements', () => {
const div = document.createElement('div')
div.contentEditable = 'plaintext-only'
expect(isInputElement(div)).toBe(true)
})

it('should return true for inherited contenteditable', () => {
const parent = document.createElement('div')
parent.contentEditable = 'true'
const child = document.createElement('span')
parent.appendChild(child)
document.body.appendChild(parent)
expect(isInputElement(child)).toBe(true)
document.body.removeChild(parent)
})

it('should return false for contenteditable false', () => {
const div = document.createElement('div')
div.contentEditable = 'false'
Expand Down
Loading