chore: stabilize consumer foundations and align trust documentation - #210
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe changes align documentation with source-aware policies, lifecycle boundaries, and observation-based hooks. They also add integration tests to the PR check and update source errors and type handling. ChangesIntent policy and lifecycle alignment
Estimated code review effort: 1 (Trivial) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 2f9f526
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 2f9f526
☁️ Nx Cloud last updated this comment at |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cli/intent-hooks.md`:
- Line 6: The hook documentation uses “available” for policy-filtered skills;
update the session-catalog terminology to “permitted” or “surfaced”
consistently. In docs/cli/intent-hooks.md lines 6 and 20-21, revise both
descriptions; in docs/getting-started/quick-start-consumers.md line 59, apply
the same terminology. Preserve the existing lifecycle distinction between
Available and Permitted.
In `@docs/cli/intent-list.md`:
- Line 19: Update the “What you get” bullet in intent-list.md to describe
--no-notices consistently: suppress non-critical notices while keeping the
acknowledged-risk notice for intent.skills: ["*"] visible.
In `@docs/cli/intent-load.md`:
- Around line 25-26: Update the pre-scan guarantee statements in the intent load
documentation to apply only to package-qualified <package>#<skill> inputs, or
explicitly document when policy and exclude checks occur for unqualified short
skill names. Keep the existing behavior description accurate for both input
forms.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c16e3060-082c-4021-a4a1-447c65e6f8ef
📒 Files selected for processing (10)
docs/cli/intent-hooks.mddocs/cli/intent-list.mddocs/cli/intent-load.mddocs/concepts/configuration.mddocs/concepts/trust-model.mddocs/getting-started/quick-start-consumers.mdpackage.jsonpackages/intent/src/shared/utils.tspackages/intent/tests/integration/source-policy-surfaces.test.tspackages/intent/tests/staleness.test.ts
| --- | ||
|
|
||
| `intent hooks install` installs lifecycle hooks that surface available Intent skills and enforce loading matching guidance before edits in supported agents. | ||
| `intent hooks install` installs lifecycle hooks that surface available Intent skills and gate supported edit tools until they observe an Intent load command. |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Use the formal lifecycle terminology for the hook catalog.
The trust model defines Available as discovered and Permitted as allowed by intent.skills and intent.exclude. The hook catalog is policy-filtered, so calling it “available” can imply that unlisted skills are surfaced.
docs/cli/intent-hooks.md#L6-L6: replace “available Intent skills” with “permitted” or “surfaced” skills.docs/cli/intent-hooks.md#L20-L21: describe the session catalog as containing permitted or surfaced entries.docs/getting-started/quick-start-consumers.md#L59-L59: use the same terminology for the session catalog.
📍 Affects 2 files
docs/cli/intent-hooks.md#L6-L6(this comment)docs/cli/intent-hooks.md#L20-L21docs/getting-started/quick-start-consumers.md#L59-L59
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/cli/intent-hooks.md` at line 6, The hook documentation uses “available”
for policy-filtered skills; update the session-catalog terminology to
“permitted” or “surfaced” consistently. In docs/cli/intent-hooks.md lines 6 and
20-21, revise both descriptions; in
docs/getting-started/quick-start-consumers.md line 59, apply the same
terminology. Preserve the existing lifecycle distinction between Available and
Permitted.
…ions' into chore/stabilize-consumer-foundations
1 participant
Summary
Prepare the current consumer foundation for later accepted-state and delivery work by running the existing integration suite in PR validation, removing stale repository and milestone references, fixing deterministic integration-test output, and aligning trust documentation with shipped behavior.
Why
The PR workflow ran unit, type, lint, docs, and build targets but omitted the existing package-manager, filesystem, PnP, load, scanner, and source-policy integration suite. The docs also described merged
intent.skills, name-only source matching, and stronger hook and agent guarantees than the current implementation provides. Correcting this base first keeps later product PRs focused and reviewable.Changes
test:integrationNx target topnpm run test:pr.build:corescript that targeted the deletedpackages/agentsworkspace.git:source error and add a patch changeset.intent.skills, accumulatedintent.exclude, kind-specific npm/workspace selectors, package-level permission, and notice behavior.loadand hook guarantees to what Intent can observe.Non-goals
This preparation PR does not introduce accepted state,
intent.lock, snapshots, new delivery modes, symlink delivery, hooks or hook behavior changes, activation, agent target selection, new configuration, new APIs, new commands, automaticpreparechanges, registries, hosted services, or new consumer workflows.Follow-ups
The planned accepted-state PR is the next product step. Delivery, maintainer experience, activation, and stable-release hardening remain separate follow-up work.
✅ Checklist
CI=1 pnpm run test:pr.🚀 Release Impact