Skip to content

fix: recognize workspace-root Intent devDependency - #266

Merged
LadyBluenotes merged 1 commit into
refactor-maintainer-read-reusefrom
fix-workspace-intent-warning
Sep 11, 2026
Merged

fix: recognize workspace-root Intent devDependency#266
LadyBluenotes merged 1 commit into
refactor-maintainer-read-reusefrom
fix-workspace-intent-warning

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

🎯 Changes

Stacked on #265. Fixes #212.

Recognize @tanstack/intent in the owning workspace root's devDependencies when validating a member package. Keep package-local declarations valid and preserve the warning when Intent is declared only by a sibling package. Package keywords and publishing checks still use the member's manifest.

Regression tests cover package.json and pnpm workspace declarations, invocation from the workspace root and member directory, and removal of the root declaration.

Verification: all 146 CLI tests passed; package typecheck, focused ESLint, Prettier, and git diff --check passed. Three existing lint warnings remain. No dependency, guide, or CI changes.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a31056fd-f601-4597-bab7-d1ceaa4e620d

📥 Commits

Reviewing files that changed from the base of the PR and between 4c63c4e and 80f0e5f.

📒 Files selected for processing (3)
  • .changeset/workspace-root-intent-warning.md
  • packages/intent/src/commands/validate.ts
  • packages/intent/tests/cli.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 11, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 259ce1b

Command Status Duration Result
nx run-many --targets=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-11 05:12:33 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@266

commit: 259ce1b

@codspeed-hq

codspeed-hq Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing fix-workspace-intent-warning (80f0e5f) with refactor-maintainer-read-reuse (549e5b8)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes added this pull request to stack #274 September 11, 2026 22:02
@LadyBluenotes
LadyBluenotes force-pushed the fix-workspace-intent-warning branch 2 times, most recently from 2578ef7 to be87e6c Compare September 11, 2026 22:25
@LadyBluenotes
LadyBluenotes force-pushed the fix-workspace-intent-warning branch from be87e6c to 80f0e5f Compare September 11, 2026 22:30
@LadyBluenotes
LadyBluenotes merged commit 7a2a9e1 into main Sep 11, 2026
8 of 13 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix-workspace-intent-warning branch September 11, 2026 22:32
@github-actions github-actions Bot mentioned this pull request Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check monorepo devdep for intent

1 participant