Conversation
… in test 'queryFn' and 'mutationFn'
Contributor
📝 WalkthroughWalkthroughThis PR converts test implementations across multiple test files from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit d2d2362
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/preact-query/src/__tests__/useMutation.test.tsx (1)
161-163: RedundantPromise.resolveinside.then()callback.The
.then()callback automatically wraps the returned value in a Promise, makingPromise.resolve(value)unnecessary. This should just returnvaluedirectly for consistency with the other changes in this PR.Suggested fix
- mutateFn.mockImplementation((value) => - sleep(10).then(() => Promise.resolve(value)), - ) + mutateFn.mockImplementation((value) => sleep(10).then(() => value))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/preact-query/src/__tests__/useMutation.test.tsx` around lines 161 - 163, The mock implementation for mutateFn uses Promise.resolve inside a .then callback which is redundant; update mutateFn.mockImplementation((value) => sleep(10).then(() => Promise.resolve(value))) to simply return the value from the .then callback (i.e., .then(() => value)) so the promise resolves the same way and matches the style of other tests; locate and change the mutateFn.mockImplementation call in useMutation.test.tsx.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/preact-query/src/__tests__/useMutation.test.tsx`:
- Around line 161-163: The mock implementation for mutateFn uses Promise.resolve
inside a .then callback which is redundant; update
mutateFn.mockImplementation((value) => sleep(10).then(() =>
Promise.resolve(value))) to simply return the value from the .then callback
(i.e., .then(() => value)) so the promise resolves the same way and matches the
style of other tests; locate and change the mutateFn.mockImplementation call in
useMutation.test.tsx.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2f567c03-2339-478d-8002-dc10b8ce68b1
📒 Files selected for processing (6)
packages/preact-query/src/__tests__/fine-grained-persister.test.tsxpackages/preact-query/src/__tests__/useMutation.test.tsxpackages/preact-query/src/__tests__/usePrefetchQuery.test.tsxpackages/preact-query/src/__tests__/useQueries.test.tsxpackages/preact-query/src/__tests__/useQuery.test.tsxpackages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
sukvvon
deleted the
test/preact-query-replace-async-await-sleep-with-then-chaining
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
async () => { await sleep(N); return value }with() => sleep(N).then(() => value)in testqueryFnandmutationFnuseQuery.test.tsx,useQueries.test.tsx,useMutation.test.tsx,usePrefetchQuery.test.tsx,useSuspenseQueries.test.tsx, andfine-grained-persister.test.tsx✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit