Skip to content

test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 2 commits into from
Apr 6, 2026
Merged

test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa15f2c
test(preact-query): replace 'async/await sleep' with 'sleep().then()'…
sukvvon Apr 6, 2026
d2d2362
ci: apply automated fixes
autofix-ci[bot] Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/preact-query/src/__tests__/fine-grained-persister.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,7 @@ describe('fine grained persister', () => {
it('should restore query state from persister and refetch', async () => {
const key = queryKey()
const hash = hashKey(key)
const spy = vi.fn(async () => {
await sleep(5)

return 'Works from queryFn'
})
const spy = vi.fn(() => sleep(5).then(() => 'Works from queryFn'))

const mapStorage = new Map()
const storage = {
Expand Down
17 changes: 5 additions & 12 deletions packages/preact-query/src/__tests__/useMutation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,9 @@ describe('useMutation', () => {
return Promise.reject(new Error('Error test Jonas'))
})

mutateFn.mockImplementation(async (value) => {
await sleep(10)
return Promise.resolve(value)
})
mutateFn.mockImplementation((value) =>
sleep(10).then(() => Promise.resolve(value)),
)

function Page() {
const { mutate, failureCount, failureReason, data, status } = useMutation(
Expand Down Expand Up @@ -370,10 +369,7 @@ describe('useMutation', () => {
const key = queryKey()

queryClient.setMutationDefaults(key, {
mutationFn: async (text: string) => {
await sleep(10)
return text
},
mutationFn: (text: string) => sleep(10).then(() => text),
})

const states: Array<UseMutationResult<any, any, any, any>> = []
Expand Down Expand Up @@ -1034,10 +1030,7 @@ describe('useMutation', () => {

function Page() {
const mutation = useMutation({
mutationFn: async (_text: string) => {
await sleep(10)
return 'result'
},
mutationFn: (_text: string) => sleep(10).then(() => 'result'),
onSuccess: () => Promise.reject(error),
onError,
})
Expand Down
6 changes: 1 addition & 5 deletions packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ import { renderWithClient } from './utils'
const generateQueryFn = (data: string) =>
vi
.fn<(...args: Array<any>) => Promise<string>>()
.mockImplementation(async () => {
await sleep(10)

return data
})
.mockImplementation(() => sleep(10).then(() => data))

describe('usePrefetchQuery', () => {
let queryCache: QueryCache
Expand Down
92 changes: 20 additions & 72 deletions packages/preact-query/src/__tests__/useQueries.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,11 @@ describe('useQueries', () => {
queries: [
{
queryKey: key1,
queryFn: async () => {
await sleep(10)
return 1
},
queryFn: () => sleep(10).then(() => 1),
},
{
queryKey: key2,
queryFn: async () => {
await sleep(200)
return 2
},
queryFn: () => sleep(200).then(() => 2),
},
],
})
Expand Down Expand Up @@ -1094,17 +1088,11 @@ describe('useQueries', () => {
queries: [
{
queryKey: key1,
queryFn: async () => {
await sleep(5)
return Promise.resolve('query1')
},
queryFn: () => sleep(5).then(() => Promise.resolve('query1')),
},
{
queryKey: key2,
queryFn: async () => {
await sleep(20)
return Promise.resolve('query2')
},
queryFn: () => sleep(20).then(() => Promise.resolve('query2')),
},
],
combine: ([query1, query2]) => {
Expand Down Expand Up @@ -1139,17 +1127,13 @@ describe('useQueries', () => {
queries: [
{
queryKey: key1,
queryFn: async () => {
await sleep(5)
return Promise.resolve(`first result ${count}`)
},
queryFn: () =>
sleep(5).then(() => Promise.resolve(`first result ${count}`)),
},
{
queryKey: key2,
queryFn: async () => {
await sleep(50)
return Promise.resolve(`second result ${count}`)
},
queryFn: () =>
sleep(50).then(() => Promise.resolve(`second result ${count}`)),
},
],
combine: (queryResults) => {
Expand Down Expand Up @@ -1331,17 +1315,11 @@ describe('useQueries', () => {
queries: [
{
queryKey: key1,
queryFn: async () => {
await sleep(10)
return `first result:${value}`
},
queryFn: () => sleep(10).then(() => `first result:${value}`),
},
{
queryKey: key2,
queryFn: async () => {
await sleep(20)
return `second result:${value}`
},
queryFn: () => sleep(20).then(() => `second result:${value}`),
},
],
combine: useCallback((results: Array<QueryObserverResult>) => {
Expand Down Expand Up @@ -1415,17 +1393,11 @@ describe('useQueries', () => {
queries: [
{
queryKey: [key1],
queryFn: async () => {
await sleep(10)
return 'first result'
},
queryFn: () => sleep(10).then(() => 'first result'),
},
{
queryKey: [key2],
queryFn: async () => {
await sleep(20)
return 'second result'
},
queryFn: () => sleep(20).then(() => 'second result'),
},
],
combine: useCallback(
Expand Down Expand Up @@ -1539,24 +1511,15 @@ describe('useQueries', () => {
queries: [
{
queryKey: [key1],
queryFn: async () => {
await sleep(10)
return 'first result'
},
queryFn: () => sleep(10).then(() => 'first result'),
},
{
queryKey: [key2],
queryFn: async () => {
await sleep(15)
return 'second result'
},
queryFn: () => sleep(15).then(() => 'second result'),
},
{
queryKey: [key3],
queryFn: async () => {
await sleep(20)
return 'third result'
},
queryFn: () => sleep(20).then(() => 'third result'),
},
],
combine: (results) => {
Expand Down Expand Up @@ -1601,24 +1564,15 @@ describe('useQueries', () => {
queries: [
{
queryKey: [key1],
queryFn: async () => {
await sleep(10)
return 'first result'
},
queryFn: () => sleep(10).then(() => 'first result'),
},
{
queryKey: [key2],
queryFn: async () => {
await sleep(15)
return 'second result'
},
queryFn: () => sleep(15).then(() => 'second result'),
},
{
queryKey: [key3],
queryFn: async () => {
await sleep(20)
return 'third result'
},
queryFn: () => sleep(20).then(() => 'third result'),
},
],
combine: (results) => {
Expand Down Expand Up @@ -1680,17 +1634,11 @@ describe('useQueries', () => {
queries: [
{
queryKey: key1,
queryFn: async () => {
await sleep(10)
return 'first result'
},
queryFn: () => sleep(10).then(() => 'first result'),
},
{
queryKey: key2,
queryFn: async () => {
await sleep(20)
return 'second result'
},
queryFn: () => sleep(20).then(() => 'second result'),
},
],
combine: useCallback((results: Array<QueryObserverResult>) => {
Expand Down
Loading
Loading