test({react,preact}-query/usePrefetchQuery): inline the shared 'Suspended' component into each test by sukvvon · Pull Request #11077 · TanStack/query

sukvvon · 2026-07-18T09:13:26Z

🎯 Changes

Inlines the describe-level shared Suspended component into each it block as a local Page component, so each test reads as self-contained (the hook call it exercises is visible in the test itself rather than in a shared helper). The should not create a suspense waterfall if prefetch is fired test, which nests three differently-parameterized instances, is split into three standalone local components (FirstQuery/SecondQuery/ThirdQuery) instead of one generic component taking a queryOpts prop. Applies to both react-query and preact-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded and clarified usePrefetchQuery coverage across React and Preact.
- Improved validation for prefetching, existing query state, error recovery, failed requests, and Suspense behavior.
- Added clearer coverage ensuring prefetching prevents unnecessary Suspense waterfalls.

…nded' component into each test

nx-cloud · 2026-07-18T09:13:54Z

View your CI Pipeline Execution ↗ for commit 237ad33

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	6m 8s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	28s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 09:20:52 UTC

github-actions · 2026-07-18T09:14:30Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-07-18T09:15:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 016954d3-21bc-4158-b418-a3723134f7f0

📥 Commits

Reviewing files that changed from the base of the PR and between b955f60 and 237ad33.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx
packages/react-query/src/__tests__/usePrefetchQuery.test.tsx

📝 Walkthrough

Walkthrough

Changes

Prefetch query test components

Layer / File(s)	Summary
Replace shared Suspense helper with local components `packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx`, `packages/react-query/src/__tests__/usePrefetchQuery.test.tsx`	Removed the shared `Suspended` helper and updated prefetch, error, retry, and loop tests to render local components that call `useSuspenseQuery` with closure-scoped options.
Rebuild nested suspense waterfall coverage `packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx`, `packages/react-query/src/__tests__/usePrefetchQuery.test.tsx`	Replaced nested `Suspended` elements with `FirstQuery`, `SecondQuery`, and `ThirdQuery` components for the waterfall scenario.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

TanStack/query#11075: Updates related usePrefetchQuery tests and Suspense fallback assertions.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly names the affected tests and the main refactor, and it matches the changeset.
Description check	✅ Passed	The description follows the template with changes, checklist, and release-impact sections filled in.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/inline-suspended-component-per-test

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-18T09:16:35Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11077

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11077

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11077

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11077

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11077

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11077

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11077

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11077

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11077

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11077

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11077

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11077

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11077

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11077

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11077

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11077

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11077

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11077

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11077

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11077

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11077

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11077

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11077

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11077

commit: 237ad33

github-actions · 2026-07-18T09:17:14Z

size-limit report 📦

Path	Size
react full	12.13 KB (0%)
react minimal	9.08 KB (0%)

test({react,preact}-query/usePrefetchQuery): inline the shared 'Suspe…

237ad33

…nded' component into each test

coderabbitai Bot mentioned this pull request Jul 18, 2026

test({react,preact}-query/usePrefetchInfiniteQuery): inline the shared 'Suspended' component into each test #11078

Merged

4 tasks

sukvvon self-assigned this Jul 18, 2026

sukvvon merged commit dbd5a86 into main Jul 18, 2026
9 checks passed

sukvvon deleted the test/inline-suspended-component-per-test branch July 18, 2026 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test({react,preact}-query/usePrefetchQuery): inline the shared 'Suspended' component into each test#11077

test({react,preact}-query/usePrefetchQuery): inline the shared 'Suspended' component into each test#11077
sukvvon merged 1 commit into
mainfrom
test/inline-suspended-component-per-test

sukvvon commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Jul 18, 2026 •

edited

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading