docs(react-query, preact-query): use 'button' instead of undefined 'Button' in suspense guide examples - #11390
Merged
Conversation
…utton' in suspense guide examples
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Preact and React Suspense guides replace ChangesSuspense guide examples
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The React and Preact Suspense guides now use native buttons for all documented error-boundary retry actions, fixing the undefined component examples without changing library behavior. The change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 320b448
☁️ Nx Cloud last updated this comment at |
Contributor
size-limit report 📦
|
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The "Resetting Error Boundaries" examples in
guides/suspense.mduse<Button onClick={...}>Try again</Button>, butButtonis never imported or defined — copying the example as-is throwsButton is not defined. Replaced with the plain<button>element the rest of the docs' examples consistently use (e.g.disabling-queries.md,mutations.md,paginated-queries.md).docs/framework/react/guides/suspense.md: fixes both occurrences (component-based and hook-based reset examples).docs/framework/preact/guides/suspense.md: the same two occurrences in itsExampleResetComponent/ExampleResetHookoverride sections (added in docs(preact-query): add 'Suspense' and 'Testing' guides #11377, which inherited the bug from react's original viaref:).Found while reviewing #11377 for a related issue (#11389).
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
<button>element for “Try again” actions.QueryErrorResetBoundaryanduseQueryErrorResetBoundaryexamples with the same native button usage.