test({react,preact}-query/useQuery): add test for 'initialData' with a failed refetch by sukvvon · Pull Request #11420 · TanStack/query

sukvvon · 2026-09-06T06:24:25Z

Summary

Add a test verifying useQuery keeps initialData visible alongside the error state when a background refetch fails (react-query, preact-query)

Summary by CodeRabbit

Bug Fixes
- Preserved initially loaded data when a query refetch fails and enters an error state.
Tests
- Added regression coverage for this behavior across supported query integrations.

…a failed refetch

nx-cloud · 2026-09-06T06:24:51Z

View your CI Pipeline Execution ↗ for commit 4e5420a

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 5s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	12s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-06 06:29:48 UTC

coderabbitai · 2026-09-06T06:25:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4441a963-19a4-480e-b2fc-6e3f63969be4

📥 Commits

Reviewing files that changed from the base of the PR and between d5c0d1e and 4e5420a.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useQuery.test.tsx
packages/react-query/src/__tests__/useQuery.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Walkthrough

The change adds regression tests for React and Preact useQuery. Each test verifies that initialData remains available after a refetch fails and the query enters an error state.

Changes

Query data retention

Layer / File(s)	Summary
Failed refetch test coverage `packages/react-query/src/__tests__/useQuery.test.tsx`, `packages/preact-query/src/__tests__/useQuery.test.tsx`	Added tests that disable retries, trigger a rejected query, and verify that `initialData` remains available while `isError` changes to `true`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4e542

This change adds regression coverage for retaining initial query data after a background refetch fails in React and Preact. It does not alter runtime behavior, and no merge-blocking risk is identified.

Suggested reviewers: tkdodo, dogpawhat

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the main change and its motivation, but it does not use the required Changes, Checklist, or Release Impact sections from the repository template.	Add the required Changes, Checklist, and Release Impact sections. Complete the checklist items and state whether this test-only change requires a changeset.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the added regression tests for React Query and Preact Query. It identifies the failed refetch and retained initialData behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-usequery-initialdata-refetch-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-06T06:25:29Z

🚀 Changeset Version Preview

2 package(s) bumped directly, 23 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/svelte-query`	6.1.48 → 6.2.0	Changeset
`@tanstack/svelte-query-devtools`	6.1.48 → 6.2.0	Dependent
`@tanstack/svelte-query-persist-client`	6.1.48 → 6.2.0	Dependent
`@tanstack/vue-query-devtools`	6.1.48 → 6.2.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.102.8 → 5.102.9	Changeset
`@tanstack/angular-query-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/angular-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/eslint-plugin-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/lit-query`	0.2.20 → 0.2.21	Dependent
`@tanstack/preact-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/preact-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/preact-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-async-storage-persister`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-broadcast-client-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-persist-client-core`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-sync-storage-persister`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-next-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/vue-query`	5.102.8 → 5.102.9	Dependent

pkg-pr-new · 2026-09-06T06:27:14Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11420

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11420

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11420

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11420

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11420

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11420

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11420

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11420

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11420

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11420

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11420

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11420

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11420

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11420

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11420

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11420

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11420

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11420

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11420

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11420

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11420

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11420

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11420

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11420

commit: 4e5420a

github-actions · 2026-09-06T06:27:40Z

size-limit report 📦

Path	Size
react full	11.87 KB (0%)
react minimal	8.84 KB (0%)

test({react,preact}-query/useQuery): add test for 'initialData' with …

4e5420a

…a failed refetch

sukvvon self-assigned this Sep 6, 2026

sukvvon merged commit f7bbaed into main Sep 6, 2026
9 checks passed

sukvvon deleted the test/react-preact-query-usequery-initialdata-refetch-error branch September 6, 2026 13:47

Navigation Menu

Uh oh!

Uh oh!

test({react,preact}-query/useQuery): add test for 'initialData' with a failed refetch - #11420

test({react,preact}-query/useQuery): add test for 'initialData' with a failed refetch#11420
sukvvon merged 1 commit into
mainfrom
test/react-preact-query-usequery-initialdata-refetch-error

sukvvon commented Sep 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 6, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 6, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

pkg-pr-new Bot commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Sep 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented Sep 6, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 6, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 6, 2026 •

edited

Loading

coderabbitai Bot commented Sep 6, 2026 •

edited

Loading