test(solid-query/useInfiniteQuery): add test for 'initialData' with a failed refetch by sukvvon · Pull Request #11422 · TanStack/query

sukvvon · 2026-09-06T06:27:04Z

Summary

Add a test verifying useInfiniteQuery keeps initialData visible alongside the error state when a background refetch fails

Summary by CodeRabbit

Tests
- Added coverage ensuring initial data remains visible when an infinite query’s initial refetch fails.
- Verified the query transitions to an error state without clearing the previously available data.

… failed refetch

nx-cloud · 2026-09-06T06:27:28Z

View your CI Pipeline Execution ↗ for commit 27d5a65

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 33s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	6s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-06 06:30:53 UTC

coderabbitai · 2026-09-06T06:27:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c9587265-9ede-454a-ac30-5397f2dad029

📥 Commits

Reviewing files that changed from the base of the PR and between d5c0d1e and 27d5a65.

📒 Files selected for processing (1)

packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

Adds a useInfiniteQuery test that verifies initialData remains visible when the initial fetch fails with retries disabled. The test also verifies the transition from isError: false to isError: true.

Changes

Infinite query error-state coverage

Layer / File(s)	Summary
Initial data retention test `packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx`	Adds a test with `initialData`, `retry: false`, and a rejecting `queryFn`. The test verifies that the initial page data remains available while `isError` changes to `true`.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 27d5a

This change adds coverage ensuring initial infinite-query data remains visible when a failed fetch enters an error state. No current merge-blocking risk is identified.

Suggested reviewers: tkdodo

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the test change and its purpose, but it does not use the required Changes, Checklist, or Release Impact sections.	Update the description to include the required template sections. Describe the changes under Changes, complete the Checklist items, and identify the release impact by selecting the applicable option under Release Impact.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding a Solid Query useInfiniteQuery test for initialData retained after a failed refetch.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/solid-query-useinfinitequery-initialdata-refetch-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-06T06:28:02Z

🚀 Changeset Version Preview

2 package(s) bumped directly, 23 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/svelte-query`	6.1.48 → 6.2.0	Changeset
`@tanstack/svelte-query-devtools`	6.1.48 → 6.2.0	Dependent
`@tanstack/svelte-query-persist-client`	6.1.48 → 6.2.0	Dependent
`@tanstack/vue-query-devtools`	6.1.48 → 6.2.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.102.8 → 5.102.9	Changeset
`@tanstack/angular-query-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/angular-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/eslint-plugin-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/lit-query`	0.2.20 → 0.2.21	Dependent
`@tanstack/preact-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/preact-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/preact-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-async-storage-persister`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-broadcast-client-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-persist-client-core`	5.102.8 → 5.102.9	Dependent
`@tanstack/query-sync-storage-persister`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-next-experimental`	5.102.8 → 5.102.9	Dependent
`@tanstack/react-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query-devtools`	5.102.8 → 5.102.9	Dependent
`@tanstack/solid-query-persist-client`	5.102.8 → 5.102.9	Dependent
`@tanstack/vue-query`	5.102.8 → 5.102.9	Dependent

pkg-pr-new · 2026-09-06T06:29:35Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11422

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11422

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11422

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11422

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11422

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11422

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11422

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11422

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11422

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11422

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11422

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11422

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11422

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11422

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11422

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11422

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11422

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11422

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11422

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11422

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11422

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11422

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11422

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11422

commit: 27d5a65

github-actions · 2026-09-06T06:29:55Z

size-limit report 📦

Path	Size
react full	11.87 KB (0%)
react minimal	8.84 KB (0%)

test(solid-query/useInfiniteQuery): add test for 'initialData' with a…

27d5a65

… failed refetch

sukvvon self-assigned this Sep 6, 2026

sukvvon merged commit 14ba7be into main Sep 6, 2026
9 checks passed

sukvvon deleted the test/solid-query-useinfinitequery-initialdata-refetch-error branch September 6, 2026 13:49

Navigation Menu

Uh oh!

Uh oh!

test(solid-query/useInfiniteQuery): add test for 'initialData' with a failed refetch - #11422

test(solid-query/useInfiniteQuery): add test for 'initialData' with a failed refetch#11422
sukvvon merged 1 commit into
mainfrom
test/solid-query-useinfinitequery-initialdata-refetch-error

sukvvon commented Sep 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 6, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 6, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

pkg-pr-new Bot commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Sep 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

github-actions Bot commented Sep 6, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 6, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 6, 2026 •

edited

Loading

coderabbitai Bot commented Sep 6, 2026 •

edited

Loading