Skip to content

do not call dispatch on removed query - #272

Merged
tannerlinsley merged 1 commit into
TanStack:masterfrom
kentcdodds:pr/fix-dispatch-on-removed-query
Mar 20, 2020
Merged

do not call dispatch on removed query#272
tannerlinsley merged 1 commit into
TanStack:masterfrom
kentcdodds:pr/fix-dispatch-on-removed-query

Conversation

@kentcdodds

Copy link
Copy Markdown
Contributor

I'm not sure why, but it looks like this is necessary afterall. I promise I tested this exact change in my app. You can watch the livestream if you don't believe me 😅

@tannerlinsley
tannerlinsley merged commit 8c519cc into TanStack:master Mar 20, 2020
@kentcdodds
kentcdodds deleted the pr/fix-dispatch-on-removed-query branch March 20, 2020 23:27
@tannerlinsley

Copy link
Copy Markdown
Member

Released 🎉

@kentcdodds

Copy link
Copy Markdown
Contributor Author

Thank you! And sorry for the trouble.

@kentcdodds

Copy link
Copy Markdown
Contributor Author

Looks like it hasn't been released yet 🤔

@tannerlinsley

Copy link
Copy Markdown
Member

Woah, looks like npm 503'd 🤷‍♂

@tannerlinsley

Copy link
Copy Markdown
Member

Released!

@kentcdodds

Copy link
Copy Markdown
Contributor Author

Looks like this wasn't in that release 🤔

https://unpkg.com/browse/react-query@1.0.32/dist/react-query.development.js

@tannerlinsley

tannerlinsley commented Mar 21, 2020 via email

Copy link
Copy Markdown
Member

@tannerlinsley

Copy link
Copy Markdown
Member

Alright, third time is a charm

@kentcdodds

Copy link
Copy Markdown
Contributor Author

Sweet. I'll check it out next will. Thanks!

@nx-cloud

nx-cloud Bot commented Feb 10, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 2f5c331

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 54s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-20 03:59:44 UTC

GEREGUR pushed a commit to GEREGUR/query that referenced this pull request Feb 17, 2026
* fix: `components` prop no-longer exists

* feat: padding on the sides of the content for large screens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants