Skip to content

fix(devTools styles): add direction style#4283

Merged
TkDodo merged 2 commits into
mainfrom
unknown repository
Oct 8, 2022
Merged

fix(devTools styles): add direction style#4283
TkDodo merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 7, 2022

Copy link
Copy Markdown

Add dir="ltr" to devtools panel beacause the devtools appear inverted when direction of a parent is rtl

Fixes #4282

Add dir="ltr" to devtools panel beacause the devtools appear inverted when direction of a parent is rtl

Fixes #4282
@codesandbox-ci

codesandbox-ci Bot commented Oct 7, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6294fd:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration
distracted-nash-ocxyk1 Issue #4282

@TkDodo

TkDodo commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

thanks, please run the code changes through prettier

Missing space caused CI check to fail

Fixes #4282
@ghost

ghost commented Oct 8, 2022

Copy link
Copy Markdown
Author

Please review the changes, I ran the code through prettier

@codecov-commenter

codecov-commenter commented Oct 8, 2022

Copy link
Copy Markdown

Codecov Report

Base: 96.36% // Head: 96.94% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (a6294fd) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4283      +/-   ##
==========================================
+ Coverage   96.36%   96.94%   +0.58%     
==========================================
  Files          45       86      +41     
  Lines        2281     3273     +992     
  Branches      640      881     +241     
==========================================
+ Hits         2198     3173     +975     
- Misses         80       98      +18     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/core/hydration.ts
src/react/useMutation.ts
src/core/retryer.ts
src/devtools/theme.tsx
src/core/focusManager.ts
src/core/queryClient.ts
src/core/queriesObserver.ts
src/react/useInfiniteQuery.ts
src/react/useIsFetching.ts
src/react/useIsMutating.ts
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo
TkDodo merged commit 31d799d into TanStack:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devtools appear inverted when page direction is rtl

3 participants