Skip to content

fix(types): improve v2 types#655

Merged
tannerlinsley merged 2 commits into
TanStack:masterfrom
jelteliekens:master
Jun 29, 2020
Merged

fix(types): improve v2 types#655
tannerlinsley merged 2 commits into
TanStack:masterfrom
jelteliekens:master

Conversation

@jelteliekens

Copy link
Copy Markdown
Contributor
  • Fix missing argument variables in onError and onSettled in the mutation options.
  • Add generic TSnapshot for snapshot value so the correct type is available in onError and onSettled.
  • Add generic TResult in BaseQueryOptions which removes the need of using any in onSuccess and onSettled.

@tannerlinsley
tannerlinsley merged commit bb3535d into TanStack:master Jun 29, 2020
@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

GEREGUR pushed a commit to GEREGUR/query that referenced this pull request Feb 17, 2026
* wip: Introduce FormInput and Badge components; refactor existing components to use them

* feat: Replace status indicators with Badge component in submissions and users

* feat: Replace input fields with FormInput component in moderation and feedback sections

* feat: Replace button elements with Button component in various pages

* feat: Add Button component with customizable styles and variants

* Change ui.dev to Fireship (TanStack#654)

* change ui.dev to Fireship

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* wip: Introduce FormInput and Badge components; refactor existing components to use them

* Change ui.dev to Fireship (TanStack#654)

* change ui.dev to Fireship

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* wip: Introduce FormInput and Badge components; refactor existing components to use them

* Change ui.dev to Fireship (TanStack#654)

* change ui.dev to Fireship

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* ci: apply automated fixes

---------

Co-authored-by: Lynn Fisher <lynnandtonic@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@nx-cloud

nx-cloud Bot commented Apr 29, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit bd7a9de

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-22 08:06:51 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants