Skip to content

docs: Point to latest eslint rule doc link#6768

Merged
lachlancollins merged 1 commit into
TanStack:mainfrom
nubinary:fix/eslint-rule-doc-link
Jan 26, 2024
Merged

docs: Point to latest eslint rule doc link#6768
lachlancollins merged 1 commit into
TanStack:mainfrom
nubinary:fix/eslint-rule-doc-link

Conversation

@jprosevear

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jan 25, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 11:53pm

@codesandbox-ci

codesandbox-ci Bot commented Jan 25, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e50f736:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@jprosevear jprosevear changed the title Point to latest eslint rule doc link docs: Point to latest eslint rule doc link Jan 25, 2024
@lachlancollins

Copy link
Copy Markdown
Member

Hi @jprosevear , I think you need to add framework to the path (https://tanstack.com/query/latest/docs/framework/react/eslint/${ruleName})

Comment thread packages/eslint-plugin-query/src/utils/create-rule.ts Outdated
@jprosevear

Copy link
Copy Markdown
Contributor Author

@lachlancollins @TkDodo updated

@lachlancollins

Copy link
Copy Markdown
Member

@jprosevear I think you'll need to remove the extra newline

@nx-cloud

nx-cloud Bot commented Jan 26, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e50f736. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jprosevear

Copy link
Copy Markdown
Contributor Author

@jprosevear I think you'll need to remove the extra newline

@lachlancollins Yup. For some reason i had autoformat on save temporarily off. Fixed.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c22ca89) 0.00% compared to head (e50f736) 84.79%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #6768       +/-   ##
=========================================
+ Coverage      0   84.79%   +84.79%     
=========================================
  Files         0       12       +12     
  Lines         0      342      +342     
  Branches      0      123      +123     
=========================================
+ Hits          0      290      +290     
- Misses        0       38       +38     
- Partials      0       14       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins
lachlancollins merged commit b34480d into TanStack:main Jan 26, 2024
@jprosevear
jprosevear deleted the fix/eslint-rule-doc-link branch January 27, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants