fix(types): queryCache.getQueries#688
Merged
Merged
Conversation
added 2 commits
July 1, 2020 15:45
Contributor
this type should be added to almost all queryCache methods: getQueryData, setQueryData, getQuery, getQueries type QueryKeyOrPredicateFn:
| AnyQueryKey
| string
| boolean
| ((query: CachedQuery<unknown>) => boolean) |
Contributor
Author
|
@smashercosmo Sounds good! I wasn't sure how far I should go with it. I just pushed an update. |
added 6 commits
July 1, 2020 22:33
Contributor
Author
|
Sorry about all of the weird extraneous commits, I was just trying to get the checks into a good state, there seems to be a preexisting race condition/timeout/something in a test or two 😢 |
Contributor
|
@all-contributors Please add @jgettings for code |
Contributor
|
I've put up a pull request to add @jgettings! 🎉 |
Member
|
🎉 This PR is included in version 2.4.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
View your CI Pipeline Execution ↗ for commit 5e34696
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some missing types in the getQueries method's type definitions. I copied the parameter types from the other methods that allow
AnyQueryKey | string | function, and addedbooleanas it looks like that's also a possible parameter type, looking at the implementation.