e2e/react-start/basic-tsr-config: test pass despite suite is broken

[birkskyum]

Which project does this relate to?

React Start

Describe the bug

This suite:

e2e/react-start/basic-tsr-config:

It's supposed to change the value of a button on click form "'Add 1 to 0?'" to "'Add 1 to 1?'", but it doesn't and the test still pass.

Your Example Website or App

e2e/react-start/basic-tsr-config

Steps to Reproduce the Bug or Issue

pnpm run test:e2e

to make it more thorough change in the test file:

await expect(page.getByText('Add 1 to 0?')).toBeTruthy()
await page.click('button')
await expect(page.getByText('Add 1 to 1?')).toBeTruthy()

to

await expect(page.getByText('Add 1 to 0?')).toContainText('Add 1 to 0?')
await page.click('button')
await expect(page.getByText('Add 1 to 1?')).toContainText('Add 1 to 1?')

and now it'll fail because the value isn't updated

Expected behavior

that the test either update the button value, or fail when it doesn't.

pnpm run dev and clicking this button should update it.

Screenshots or Videos

No response

Platform

• OS: [e.g. macOS, Windows, Linux]
• Browser: [e.g. Chrome, Safari, Firefox]
• Version: [e.g. 91.1]

Additional context

No response